From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Haotian Zhang <vulab@iscas.ac.cn>,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Haotian Zhang <vulab@iscas.ac.cn>
Subject: Re: [PATCH v2] crypto: sa2ul: Add error handling for DMA metadata retrieval
Date: Wed, 19 Nov 2025 14:39:20 +0300 [thread overview]
Message-ID: <202511191706.iBCITtX2-lkp@intel.com> (raw)
In-Reply-To: <20251117023117.90-1-vulab@iscas.ac.cn>
Hi Haotian,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Haotian-Zhang/crypto-sa2ul-Add-error-handling-for-DMA-metadata-retrieval/20251117-103258
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/20251117023117.90-1-vulab%40iscas.ac.cn
patch subject: [PATCH v2] crypto: sa2ul: Add error handling for DMA metadata retrieval
config: m68k-randconfig-r073-20251119 (https://download.01.org/0day-ci/archive/20251119/202511191706.iBCITtX2-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202511191706.iBCITtX2-lkp@intel.com/
smatch warnings:
drivers/crypto/sa2ul.c:1064 sa_aes_dma_in_callback() warn: 'mdptr' can also be NULL
drivers/crypto/sa2ul.c:1394 sa_sha_dma_in_callback() warn: 'mdptr' can also be NULL
drivers/crypto/sa2ul.c:1709 sa_aead_dma_in_callback() warn: 'mdptr' can also be NULL
vim +/mdptr +1064 drivers/crypto/sa2ul.c
7694b6ca649fea Keerthy 2020-07-13 1039 static void sa_aes_dma_in_callback(void *data)
7694b6ca649fea Keerthy 2020-07-13 1040 {
aedf818b1f1965 Yu Zhe 2023-03-17 1041 struct sa_rx_data *rxd = data;
7694b6ca649fea Keerthy 2020-07-13 1042 struct skcipher_request *req;
7694b6ca649fea Keerthy 2020-07-13 1043 u32 *result;
7694b6ca649fea Keerthy 2020-07-13 1044 __be32 *mdptr;
7694b6ca649fea Keerthy 2020-07-13 1045 size_t ml, pl;
7694b6ca649fea Keerthy 2020-07-13 1046 int i;
7694b6ca649fea Keerthy 2020-07-13 1047
00c9211f60db2d Peter Ujfalusi 2020-09-23 1048 sa_sync_from_device(rxd);
7694b6ca649fea Keerthy 2020-07-13 1049 req = container_of(rxd->req, struct skcipher_request, base);
7694b6ca649fea Keerthy 2020-07-13 1050
7694b6ca649fea Keerthy 2020-07-13 1051 if (req->iv) {
7694b6ca649fea Keerthy 2020-07-13 1052 mdptr = (__be32 *)dmaengine_desc_get_metadata_ptr(rxd->tx_in, &pl,
7694b6ca649fea Keerthy 2020-07-13 1053 &ml);
The Kconfig file should probably enforce that CONFIG_DMA_ENGINE
is set. Otherwise dmaengine_desc_get_metadata_ptr() returns NULL.
90d79e983588a8 Haotian Zhang 2025-11-17 1054 if (IS_ERR(mdptr)) {
90d79e983588a8 Haotian Zhang 2025-11-17 1055 dev_err(rxd->ddev, "Failed to get AES RX metadata pointer: %ld\n",
90d79e983588a8 Haotian Zhang 2025-11-17 1056 PTR_ERR(mdptr));
90d79e983588a8 Haotian Zhang 2025-11-17 1057 sa_free_sa_rx_data(rxd);
90d79e983588a8 Haotian Zhang 2025-11-17 1058 skcipher_request_complete(req, PTR_ERR(mdptr));
90d79e983588a8 Haotian Zhang 2025-11-17 1059 return;
90d79e983588a8 Haotian Zhang 2025-11-17 1060 }
7694b6ca649fea Keerthy 2020-07-13 1061 result = (u32 *)req->iv;
7694b6ca649fea Keerthy 2020-07-13 1062
7694b6ca649fea Keerthy 2020-07-13 1063 for (i = 0; i < (rxd->enc_iv_size / 4); i++)
7694b6ca649fea Keerthy 2020-07-13 @1064 result[i] = be32_to_cpu(mdptr[i + rxd->iv_idx]);
7694b6ca649fea Keerthy 2020-07-13 1065 }
7694b6ca649fea Keerthy 2020-07-13 1066
00c9211f60db2d Peter Ujfalusi 2020-09-23 1067 sa_free_sa_rx_data(rxd);
7694b6ca649fea Keerthy 2020-07-13 1068
7694b6ca649fea Keerthy 2020-07-13 1069 skcipher_request_complete(req, 0);
7694b6ca649fea Keerthy 2020-07-13 1070 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-11-19 11:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 2:31 [PATCH v2] crypto: sa2ul: Add error handling for DMA metadata retrieval Haotian Zhang
2025-11-19 11:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511191706.iBCITtX2-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox