The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05
@ 2025-11-24 12:39 Daniel Schultz
  2025-11-24 12:39 ` [PATCH 2/2] dt-bindings: display: simple: " Daniel Schultz
  2025-11-24 12:51 ` [PATCH 1/2] drm/panel: panel-simple: " Maxime Ripard
  0 siblings, 2 replies; 6+ messages in thread
From: Daniel Schultz @ 2025-11-24 12:39 UTC (permalink / raw)
  To: neil.armstrong, jessica.zhang, maarten.lankhorst, mripard,
	tzimmermann, airlied, simona, robh, krzk+dt, conor+dt,
	thierry.reding, sam, dri-devel, devicetree, linux-kernel
  Cc: upstream, Daniel Schultz

Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 0019de93be1b..9ad6beeb9952 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -4266,6 +4266,31 @@ static const struct panel_desc sharp_lq070y3dg3b = {
 		     DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,
 };
 
+static const struct display_timing sharp_lq070y3lg05_timing = {
+	.pixelclock = { 28000000, 33000000, 40000000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 40, 40, 40 },
+	.hback_porch = { 40, 40, 40 },
+	.hsync_len = { 48, 48, 48 },
+	.vactive = { 480, 480, 480 },
+	.vfront_porch = { 13, 13, 13 },
+	.vback_porch = { 29, 29, 29 },
+	.vsync_len = { 3, 3, 3 },
+	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
+};
+
+static const struct panel_desc sharp_lq070y3lg05 = {
+	.timings = &sharp_lq070y3lg05_timing,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 154,	/* 153.6mm */
+		.height = 87,	/* 86.6mm */
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode sharp_lq035q7db03_mode = {
 	.clock = 5500,
 	.hdisplay = 240,
@@ -5367,6 +5392,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "sharp,lq070y3dg3b",
 		.data = &sharp_lq070y3dg3b,
+	}, {
+		.compatible = "sharp,lq070y3lg05",
+		.data = &sharp_lq070y3lg05,
 	}, {
 		.compatible = "sharp,lq101k1ly04",
 		.data = &sharp_lq101k1ly04,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] dt-bindings: display: simple: Add Sharp LQ070Y3LG05
  2025-11-24 12:39 [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05 Daniel Schultz
@ 2025-11-24 12:39 ` Daniel Schultz
  2025-11-24 12:45   ` Krzysztof Kozlowski
  2025-11-24 12:51 ` [PATCH 1/2] drm/panel: panel-simple: " Maxime Ripard
  1 sibling, 1 reply; 6+ messages in thread
From: Daniel Schultz @ 2025-11-24 12:39 UTC (permalink / raw)
  To: neil.armstrong, jessica.zhang, maarten.lankhorst, mripard,
	tzimmermann, airlied, simona, robh, krzk+dt, conor+dt,
	thierry.reding, sam, dri-devel, devicetree, linux-kernel
  Cc: upstream, Daniel Schultz

Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 2017428d8828..3a55829f960b 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -284,6 +284,8 @@ properties:
       - sharp,lq035q7db03
         # Sharp LQ070Y3DG3B 7.0" WVGA landscape TFT LCD panel
       - sharp,lq070y3dg3b
+        # Sharp LQ070Y3LG05 7.0" WVGA langscape LVDS TFT LCD panel
+      - sharp,lq070y3lg05
         # Sharp Display Corp. LQ101K1LY04 10.07" WXGA TFT LCD panel
       - sharp,lq101k1ly04
         # Sharp LS020B1DD01D 2.0" HQVGA TFT LCD panel
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] dt-bindings: display: simple: Add Sharp LQ070Y3LG05
  2025-11-24 12:39 ` [PATCH 2/2] dt-bindings: display: simple: " Daniel Schultz
@ 2025-11-24 12:45   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-24 12:45 UTC (permalink / raw)
  To: Daniel Schultz, neil.armstrong, jessica.zhang, maarten.lankhorst,
	mripard, tzimmermann, airlied, simona, robh, krzk+dt, conor+dt,
	thierry.reding, sam, dri-devel, devicetree, linux-kernel
  Cc: upstream

On 24/11/2025 13:39, Daniel Schultz wrote:
> Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---



Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

In the future:
Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05
  2025-11-24 12:39 [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05 Daniel Schultz
  2025-11-24 12:39 ` [PATCH 2/2] dt-bindings: display: simple: " Daniel Schultz
@ 2025-11-24 12:51 ` Maxime Ripard
  2025-11-24 13:53   ` Daniel Schultz
  1 sibling, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2025-11-24 12:51 UTC (permalink / raw)
  To: Daniel Schultz
  Cc: neil.armstrong, jessica.zhang, maarten.lankhorst, tzimmermann,
	airlied, simona, robh, krzk+dt, conor+dt, thierry.reding, sam,
	dri-devel, devicetree, linux-kernel, upstream

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

On Mon, Nov 24, 2025 at 04:39:37AM -0800, Daniel Schultz wrote:
> Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)

Any reason to use panel-simple over panel-lvds?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05
  2025-11-24 12:51 ` [PATCH 1/2] drm/panel: panel-simple: " Maxime Ripard
@ 2025-11-24 13:53   ` Daniel Schultz
  2025-11-26  8:18     ` neil.armstrong
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Schultz @ 2025-11-24 13:53 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: neil.armstrong, jessica.zhang, maarten.lankhorst, tzimmermann,
	airlied, simona, robh, krzk+dt, conor+dt, thierry.reding, sam,
	dri-devel, devicetree, linux-kernel, upstream

On 11/24/25 13:51, Maxime Ripard wrote:
> On Mon, Nov 24, 2025 at 04:39:37AM -0800, Daniel Schultz wrote:
>> Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>>   drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
> Any reason to use panel-simple over panel-lvds?

I didn't know panel-lvds exist. I just convert these timings to 
panel-lvds and works fine, too. Thanks!

I don't plan to send my device-tree with the new timings included in the 
near future. Should or can I already add this panel as compatible to 
panel-simple.yaml?

- Daniel

>
> Maxime

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05
  2025-11-24 13:53   ` Daniel Schultz
@ 2025-11-26  8:18     ` neil.armstrong
  0 siblings, 0 replies; 6+ messages in thread
From: neil.armstrong @ 2025-11-26  8:18 UTC (permalink / raw)
  To: Daniel Schultz, Maxime Ripard
  Cc: jessica.zhang, maarten.lankhorst, tzimmermann, airlied, simona,
	robh, krzk+dt, conor+dt, thierry.reding, sam, dri-devel,
	devicetree, linux-kernel, upstream

On 11/24/25 14:53, Daniel Schultz wrote:
> On 11/24/25 13:51, Maxime Ripard wrote:
>> On Mon, Nov 24, 2025 at 04:39:37AM -0800, Daniel Schultz wrote:
>>> Add the Sharp LQ070Y3LG05 7" WVGA lanscape LVDS RGB TFT-LCD panel.
>>>
>>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>>> ---
>>>   drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>>>   1 file changed, 28 insertions(+)
>> Any reason to use panel-simple over panel-lvds?
> 
> I didn't know panel-lvds exist. I just convert these timings to panel-lvds and works fine, too. Thanks!
> 
> I don't plan to send my device-tree with the new timings included in the near future. Should or can I already add this panel as compatible to panel-simple.yaml?

Any reason why it won't fit in Documentation/devicetree/bindings/display/panel/panel-lvds.yaml ?

Neil

> 
> - Daniel
> 
>>
>> Maxime


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-11-26  8:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-24 12:39 [PATCH 1/2] drm/panel: panel-simple: Add Sharp LQ070Y3LG05 Daniel Schultz
2025-11-24 12:39 ` [PATCH 2/2] dt-bindings: display: simple: " Daniel Schultz
2025-11-24 12:45   ` Krzysztof Kozlowski
2025-11-24 12:51 ` [PATCH 1/2] drm/panel: panel-simple: " Maxime Ripard
2025-11-24 13:53   ` Daniel Schultz
2025-11-26  8:18     ` neil.armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox