From: Peter Zijlstra <peterz@infradead.org>
To: Alexandre Chartre <alexandre.chartre@oracle.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
jpoimboe@kernel.org, david.laight.linux@gmail.com
Subject: Re: [PATCH v6 26/30 (mawk fix)] objtool: Add function to get the name of a CPU feature
Date: Mon, 24 Nov 2025 20:35:45 +0100 [thread overview]
Message-ID: <20251124193545.GV3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251124164855.1036513-1-alexandre.chartre@oracle.com>
On Mon, Nov 24, 2025 at 05:48:55PM +0100, Alexandre Chartre wrote:
> diff --git a/tools/objtool/arch/x86/Build b/tools/objtool/arch/x86/Build
> index 3dedb2fd8f3a0..b95448ee01ee4 100644
> --- a/tools/objtool/arch/x86/Build
> +++ b/tools/objtool/arch/x86/Build
> @@ -12,3 +12,13 @@ $(OUTPUT)arch/x86/lib/inat-tables.c: $(inat_tables_script) $(inat_tables_maps)
> $(OUTPUT)arch/x86/decode.o: $(OUTPUT)arch/x86/lib/inat-tables.c
>
> CFLAGS_decode.o += -I$(OUTPUT)arch/x86/lib
> +
> +cpu_features = ../arch/x86/include/asm/cpufeatures.h
> +cpu_features_script = ../arch/x86/tools/gen-cpu-feature-names-x86.awk
> +
> +$(OUTPUT)arch/x86/lib/cpu-feature-names.c: $(cpu_features_script) $(cpu_features)
> + $(Q)$(call echo-cmd,gen)$(AWK) -f $(cpu_features_script) $(cpu_features) > $@
> +
> +$(OUTPUT)arch/x86/special.o: $(OUTPUT)arch/x86/lib/cpu-feature-names.c
> +
> +CFLAGS_special.o := -I$(OUTPUT)arch/x86/lib
If you'd been careful, you'd have taken the commit from tip and noticed
its Build fragment is slightly different :-)
You're now re-introducing a race in the build where if you build
special.o before decode.o the lib directory isn't yet created and it
goes sideways.
Anyway, let me fold that awk delta into what I have.
Thanks!
next prev parent reply other threads:[~2025-11-24 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:48 [PATCH v6 26/30 (mawk fix)] objtool: Add function to get the name of a CPU feature Alexandre Chartre
2025-11-24 19:35 ` Peter Zijlstra [this message]
2025-11-24 19:45 ` Peter Zijlstra
2025-11-25 7:55 ` Alexandre Chartre
2025-11-25 13:29 ` David Laight
2025-11-25 14:43 ` Alexandre Chartre
2025-11-25 18:34 ` David Laight
2025-11-25 19:36 ` Alexandre Chartre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124193545.GV3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexandre.chartre@oracle.com \
--cc=david.laight.linux@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox