[PATCH 0/2] clk: microchip: core: fix issue with round_rate conversion and allow compile test

[PATCH 0/2] clk: microchip: core: fix issue with round_rate conversion and allow compile test

[Brian Masney]

Here's a series that fixes an issue that fixes an issue with my
round_rate conversion on this PIC32 driver, and a change that allows
building this driver on other architectures with COMPILE_TEST enabled.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Brian Masney (2):
      clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops
      clk: microchip: core: allow driver to be compiled with COMPILE_TEST

 drivers/clk/microchip/Kconfig    |  2 +-
 drivers/clk/microchip/clk-core.c | 20 +++++++++-----------
 2 files changed, 10 insertions(+), 12 deletions(-)
---
base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
change-id: 20251125-clk-microchip-fixes-d0864e21ef0d

Best regards,
-- 
Brian Masney <bmasney@redhat.com>

[PATCH 1/2] clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops

[Brian Masney]

pic32_sclk_ops previously had a sclk_round_rate() member, and this was
recently converted over to sclk_determine_rate() with the help of a
Coccinelle semantic patch. pic32_sclk_ops now has two conflicting
determine_rate ops members.

Prior to the conversion, pic32_sclk_ops already had a determine_rate
member that points to __clk_mux_determine_rate(). When both the
round_rate() and determine_rate() ops are defined, the clk core only
uses the determine_rate() op. Let's go ahead and drop the recently
converted sclk_determine_rate() to match the previous functionality
prior to the conversion.

Fixes: e9f039c08cdc ("clk: microchip: core: convert from round_rate() to determine_rate()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202511222115.uvHrP95A-lkp@intel.com/
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 drivers/clk/microchip/clk-core.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-core.c
index b34348d491f3e1b576b2b9a8a66bfddd8c2296ea..a0163441dfe5c1dfc27dae48e64cf3cb3d6b764f 100644
--- a/drivers/clk/microchip/clk-core.c
+++ b/drivers/clk/microchip/clk-core.c
@@ -780,15 +780,6 @@ static unsigned long sclk_get_rate(struct clk_hw *hw, unsigned long parent_rate)
 	return parent_rate / div;
 }
 
-static int sclk_determine_rate(struct clk_hw *hw,
-			       struct clk_rate_request *req)
-{
-	req->rate = calc_best_divided_rate(req->rate, req->best_parent_rate,
-					   SLEW_SYSDIV, 1);
-
-	return 0;
-}
-
 static int sclk_set_rate(struct clk_hw *hw,
 			 unsigned long rate, unsigned long parent_rate)
 {
@@ -912,7 +903,6 @@ static int sclk_init(struct clk_hw *hw)
 const struct clk_ops pic32_sclk_ops = {
 	.get_parent	= sclk_get_parent,
 	.set_parent	= sclk_set_parent,
-	.determine_rate = sclk_determine_rate,
 	.set_rate	= sclk_set_rate,
 	.recalc_rate	= sclk_get_rate,
 	.init		= sclk_init,

-- 
2.51.1

[PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[Brian Masney]

This driver currently only supports builds against a PIC32 target. To
avoid future breakage in the future, let's update the Kconfig and the
driver so that it can be built with CONFIG_COMPILE_TEST enabled.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
 drivers/clk/microchip/Kconfig    |  2 +-
 drivers/clk/microchip/clk-core.c | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/microchip/Kconfig b/drivers/clk/microchip/Kconfig
index 1b9e43eb54976b219a0277cc971f353fd6af226a..1e56a057319d97e20440fe4e107d26fa85c95ab1 100644
--- a/drivers/clk/microchip/Kconfig
+++ b/drivers/clk/microchip/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 
 config COMMON_CLK_PIC32
-	def_bool COMMON_CLK && MACH_PIC32
+	def_bool (COMMON_CLK && MACH_PIC32) || COMPILE_TEST
 
 config MCHP_CLK_MPFS
 	bool "Clk driver for PolarFire SoC"
diff --git a/drivers/clk/microchip/clk-core.c b/drivers/clk/microchip/clk-core.c
index a0163441dfe5c1dfc27dae48e64cf3cb3d6b764f..c58f4289525d5d2c8449b96119fc70a3829d9f7e 100644
--- a/drivers/clk/microchip/clk-core.c
+++ b/drivers/clk/microchip/clk-core.c
@@ -9,9 +9,17 @@
 #include <linux/interrupt.h>
 #include <linux/io.h>
 #include <linux/iopoll.h>
-#include <asm/mach-pic32/pic32.h>
 #include <asm/traps.h>
 
+#if !defined(CONFIG_MACH_PIC32) && defined(CONFIG_COMPILE_TEST)
+#define PIC32_CLR(_reg)		((_reg) + 0x04)
+#define PIC32_SET(_reg)		((_reg) + 0x08)
+#define PIC32_INV(_reg)		((_reg) + 0x0C)
+#define pic32_syskey_unlock()
+#else
+#include <asm/mach-pic32/pic32.h>
+#endif
+
 #include "clk-core.h"
 
 /* OSCCON Reg fields */

-- 
2.51.1

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[kernel test robot]

Hi Brian,

kernel test robot noticed the following build errors:

[auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
config: loongarch-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511270924.0uDTpEE9-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/microchip/clk-core.c:12:10: fatal error: 'asm/traps.h' file not found
      12 | #include <asm/traps.h>
         |          ^~~~~~~~~~~~~
   1 error generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for TSM
   Depends on [n]: VIRT_DRIVERS [=n]
   Selected by [y]:
   - PCI_TSM [=y] && PCI [=y]


vim +12 drivers/clk/microchip/clk-core.c

ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12  #include <asm/traps.h>
ce6e1188465998 Purna Chandra Mandal 2016-05-13  13  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[kernel test robot]

Hi Brian,

kernel test robot noticed the following build errors:

[auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
config: riscv-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511271350.JgAhe4RA-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511271350.JgAhe4RA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511271350.JgAhe4RA-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/clk/microchip/clk-core.c:12:10: fatal error: asm/traps.h: No such file or directory
      12 | #include <asm/traps.h>
         |          ^~~~~~~~~~~~~
   compilation terminated.


vim +12 drivers/clk/microchip/clk-core.c

ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12  #include <asm/traps.h>
ce6e1188465998 Purna Chandra Mandal 2016-05-13  13  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[kernel test robot]

Hi Brian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 92fd6e84175befa1775e5c0ab682938eca27c0b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
config: um-allyesconfig (https://download.01.org/0day-ci/archive/20251127/202511271825.EYuE2LK5-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511271825.EYuE2LK5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511271825.EYuE2LK5-lkp@intel.com/

All warnings (new ones prefixed by >>):

   include/linux/compiler_types.h:617:9: note: in expansion of macro '_compiletime_assert'
     617 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |                            ^~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/entry-common.h:139:30: note: in expansion of macro 'READ_ONCE'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                              ^~~~~~~~~
   include/linux/entry-common.h:139:61: error: 'struct thread_info' has no member named 'syscall_work'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                                                             ^~
   include/linux/compiler_types.h:597:23: note: in definition of macro '__compiletime_assert'
     597 |                 if (!(condition))                                       \
         |                       ^~~~~~~~~
   include/linux/compiler_types.h:617:9: note: in expansion of macro '_compiletime_assert'
     617 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
      36 |         compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
         |         ^~~~~~~~~~~~~~~~~~
   include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
      49 |         compiletime_assert_rwonce_type(x);                              \
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/entry-common.h:139:30: note: in expansion of macro 'READ_ONCE'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                              ^~~~~~~~~
   include/linux/entry-common.h:139:61: error: 'struct thread_info' has no member named 'syscall_work'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                                                             ^~
   include/linux/compiler_types.h:567:27: note: in definition of macro '__unqual_scalar_typeof'
     567 |                 _Generic((x),                                           \
         |                           ^
   include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
      50 |         __READ_ONCE(x);                                                 \
         |         ^~~~~~~~~~~
   include/linux/entry-common.h:139:30: note: in expansion of macro 'READ_ONCE'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                              ^~~~~~~~~
   include/linux/entry-common.h:139:61: error: 'struct thread_info' has no member named 'syscall_work'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                                                             ^~
   include/asm-generic/rwonce.h:44:73: note: in definition of macro '__READ_ONCE'
      44 | #define __READ_ONCE(x)  (*(const volatile __unqual_scalar_typeof(x) *)&(x))
         |                                                                         ^
   include/linux/entry-common.h:139:30: note: in expansion of macro 'READ_ONCE'
     139 |         unsigned long work = READ_ONCE(current_thread_info()->syscall_work);
         |                              ^~~~~~~~~
   include/linux/entry-common.h:41:34: error: 'SYSCALL_WORK_SYSCALL_TRACEPOINT' undeclared (first use in this function)
      41 | #define SYSCALL_WORK_EXIT       (SYSCALL_WORK_SYSCALL_TRACEPOINT |      \
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/entry-common.h:156:29: note: in expansion of macro 'SYSCALL_WORK_EXIT'
     156 |         if (unlikely(work & SYSCALL_WORK_EXIT))
         |                             ^~~~~~~~~~~~~~~~~
   include/linux/entry-common.h:42:34: error: 'SYSCALL_WORK_SYSCALL_TRACE' undeclared (first use in this function)
      42 |                                  SYSCALL_WORK_SYSCALL_TRACE |           \
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/entry-common.h:156:29: note: in expansion of macro 'SYSCALL_WORK_EXIT'
     156 |         if (unlikely(work & SYSCALL_WORK_EXIT))
         |                             ^~~~~~~~~~~~~~~~~
   include/linux/entry-common.h:43:34: error: 'SYSCALL_WORK_SYSCALL_AUDIT' undeclared (first use in this function)
      43 |                                  SYSCALL_WORK_SYSCALL_AUDIT |           \
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/entry-common.h:156:29: note: in expansion of macro 'SYSCALL_WORK_EXIT'
     156 |         if (unlikely(work & SYSCALL_WORK_EXIT))
         |                             ^~~~~~~~~~~~~~~~~
   include/linux/entry-common.h:44:34: error: 'SYSCALL_WORK_SYSCALL_USER_DISPATCH' undeclared (first use in this function)
      44 |                                  SYSCALL_WORK_SYSCALL_USER_DISPATCH |   \
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/entry-common.h:156:29: note: in expansion of macro 'SYSCALL_WORK_EXIT'
     156 |         if (unlikely(work & SYSCALL_WORK_EXIT))
         |                             ^~~~~~~~~~~~~~~~~
   include/linux/entry-common.h:45:34: error: 'SYSCALL_WORK_SYSCALL_EXIT_TRAP' undeclared (first use in this function)
      45 |                                  SYSCALL_WORK_SYSCALL_EXIT_TRAP |       \
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/entry-common.h:156:29: note: in expansion of macro 'SYSCALL_WORK_EXIT'
     156 |         if (unlikely(work & SYSCALL_WORK_EXIT))
         |                             ^~~~~~~~~~~~~~~~~
   arch/x86/include/asm/traps.h: At top level:
>> arch/x86/include/asm/traps.h:38:26: warning: 'struct math_emu_info' declared inside parameter list will not be visible outside of this definition or declaration
      38 | void math_emulate(struct math_emu_info *);
         |                          ^~~~~~~~~~~~~
>> arch/x86/include/asm/traps.h:45:46: warning: 'struct stack_info' declared inside parameter list will not be visible outside of this definition or declaration
      45 |                                       struct stack_info *info);
         |                                              ^~~~~~~~~~
   arch/x86/include/asm/traps.h: In function 'cond_local_irq_enable':
   arch/x86/include/asm/traps.h:50:17: error: 'struct pt_regs' has no member named 'flags'
      50 |         if (regs->flags & X86_EFLAGS_IF)
         |                 ^~
   arch/x86/include/asm/traps.h:50:27: error: 'X86_EFLAGS_IF' undeclared (first use in this function)
      50 |         if (regs->flags & X86_EFLAGS_IF)
         |                           ^~~~~~~~~~~~~
   arch/x86/include/asm/traps.h: In function 'cond_local_irq_disable':
   arch/x86/include/asm/traps.h:56:17: error: 'struct pt_regs' has no member named 'flags'
      56 |         if (regs->flags & X86_EFLAGS_IF)
         |                 ^~
   arch/x86/include/asm/traps.h:56:27: error: 'X86_EFLAGS_IF' undeclared (first use in this function)
      56 |         if (regs->flags & X86_EFLAGS_IF)
         |                           ^~~~~~~~~~~~~


vim +38 arch/x86/include/asm/traps.h

da654b74bda14c include/asm-x86/traps.h      Srinivasa Ds    2008-09-23  37  
d315760ffa261c arch/x86/include/asm/traps.h Tejun Heo       2009-02-09 @38  void math_emulate(struct math_emu_info *);
6ac8d51f01d345 include/asm-x86/traps.h      Jaswinder Singh 2008-07-15  39  
300638101329e8 arch/x86/include/asm/traps.h Tony Luck       2020-10-06  40  bool fault_in_kernel_space(unsigned long address);
300638101329e8 arch/x86/include/asm/traps.h Tony Luck       2020-10-06  41  
6271cfdfc0e473 arch/x86/include/asm/traps.h Andy Lutomirski 2016-08-30  42  #ifdef CONFIG_VMAP_STACK
44b979fa302cab arch/x86/include/asm/traps.h Peter Zijlstra  2021-09-15  43  void __noreturn handle_stack_overflow(struct pt_regs *regs,
44b979fa302cab arch/x86/include/asm/traps.h Peter Zijlstra  2021-09-15  44  				      unsigned long fault_address,
44b979fa302cab arch/x86/include/asm/traps.h Peter Zijlstra  2021-09-15 @45  				      struct stack_info *info);
6271cfdfc0e473 arch/x86/include/asm/traps.h Andy Lutomirski 2016-08-30  46  #endif
6271cfdfc0e473 arch/x86/include/asm/traps.h Andy Lutomirski 2016-08-30  47  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[Brian Masney]

On Thu, Nov 27, 2025 at 10:11:12AM +0800, kernel test robot wrote:
> Hi Brian,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
> base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
> patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
> patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
> config: loongarch-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202511270924.0uDTpEE9-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/clk/microchip/clk-core.c:12:10: fatal error: 'asm/traps.h' file not found
>       12 | #include <asm/traps.h>
>          |          ^~~~~~~~~~~~~
>    1 error generated.
> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for TSM
>    Depends on [n]: VIRT_DRIVERS [=n]
>    Selected by [y]:
>    - PCI_TSM [=y] && PCI [=y]
> 
> 
> vim +12 drivers/clk/microchip/clk-core.c
> 
> ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12  #include <asm/traps.h>
> ce6e1188465998 Purna Chandra Mandal 2016-05-13  13  

I only build tested this on arm64. I'll post a v2.

Thanks,

Brian

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]

On Mon, Dec 01, 2025 at 01:01:25PM -0500, Brian Masney wrote:
> On Thu, Nov 27, 2025 at 10:11:12AM +0800, kernel test robot wrote:
> > Hi Brian,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
> > base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
> > patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
> > patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
> > config: loongarch-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202511270924.0uDTpEE9-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> drivers/clk/microchip/clk-core.c:12:10: fatal error: 'asm/traps.h' file not found
> >       12 | #include <asm/traps.h>
> >          |          ^~~~~~~~~~~~~
> >    1 error generated.
> > 
> > Kconfig warnings: (for reference only)
> >    WARNING: unmet direct dependencies detected for TSM
> >    Depends on [n]: VIRT_DRIVERS [=n]
> >    Selected by [y]:
> >    - PCI_TSM [=y] && PCI [=y]
> > 
> > 
> > vim +12 drivers/clk/microchip/clk-core.c
> > 
> > ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12  #include <asm/traps.h>
> > ce6e1188465998 Purna Chandra Mandal 2016-05-13  13  
> 
> I only build tested this on arm64. I'll post a v2.

MIPS I believe is where this is used.

Hmm, I think this is in a MAINTAINERS blind spot, Claudiu not CCed on
it. We should probably do something about that. Can you CC him on v2?

Cheers,
Conor.

Also, I *hate* the name of this driver, far too generic and seeing
patches for it always jumpscares me.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[Brian Masney]

Hi Conor and Claudiu,

On Mon, Dec 01, 2025 at 06:09:25PM +0000, Conor Dooley wrote:
> On Mon, Dec 01, 2025 at 01:01:25PM -0500, Brian Masney wrote:
> > On Thu, Nov 27, 2025 at 10:11:12AM +0800, kernel test robot wrote:
> > > Hi Brian,
> > > 
> > > kernel test robot noticed the following build errors:
> > > 
> > > [auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]
> > > 
> > > url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
> > > base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
> > > patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
> > > patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
> > > config: loongarch-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/config)
> > > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202511270924.0uDTpEE9-lkp@intel.com/
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > >> drivers/clk/microchip/clk-core.c:12:10: fatal error: 'asm/traps.h' file not found
> > >       12 | #include <asm/traps.h>
> > >          |          ^~~~~~~~~~~~~
> > >    1 error generated.
> > > 
> > > Kconfig warnings: (for reference only)
> > >    WARNING: unmet direct dependencies detected for TSM
> > >    Depends on [n]: VIRT_DRIVERS [=n]
> > >    Selected by [y]:
> > >    - PCI_TSM [=y] && PCI [=y]
> > > 
> > > 
> > > vim +12 drivers/clk/microchip/clk-core.c
> > > 
> > > ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12  #include <asm/traps.h>
> > > ce6e1188465998 Purna Chandra Mandal 2016-05-13  13  
> > 
> > I only build tested this on arm64. I'll post a v2.
> 
> MIPS I believe is where this is used.

So looking into this further, it looks like asm/traps.h is actually not
used by this driver, so I'll go ahead and drop that include in v2.

> Hmm, I think this is in a MAINTAINERS blind spot, Claudiu not CCed on
> it. We should probably do something about that. Can you CC him on v2?

Yes, I'll CC Claudiu. I don't see any existing entries in MAINTAINERS
where it looks like this driver would fit neatly.

Brian

Re: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 3196 bytes --]

On Mon, Dec 01, 2025 at 04:09:17PM -0500, Brian Masney wrote:
> Hi Conor and Claudiu,
> 
> On Mon, Dec 01, 2025 at 06:09:25PM +0000, Conor Dooley wrote:
> > On Mon, Dec 01, 2025 at 01:01:25PM -0500, Brian Masney wrote:
> > > On Thu, Nov 27, 2025 at 10:11:12AM +0800, kernel test robot wrote:
> > > > Hi Brian,
> > > > 
> > > > kernel test robot noticed the following build errors:
> > > > 
> > > > [auto build test ERROR on 92fd6e84175befa1775e5c0ab682938eca27c0b2]
> > > > 
> > > > url:    https://github.com/intel-lab-lkp/linux/commits/Brian-Masney/clk-microchip-core-remove-duplicate-determine_rate-on-pic32_sclk_ops/20251126-035403
> > > > base:   92fd6e84175befa1775e5c0ab682938eca27c0b2
> > > > patch link:    https://lore.kernel.org/r/20251125-clk-microchip-fixes-v1-2-6c1f5573d1b9%40redhat.com
> > > > patch subject: [PATCH 2/2] clk: microchip: core: allow driver to be compiled with COMPILE_TEST
> > > > config: loongarch-randconfig-001-20251127 (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/config)
> > > > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 9e9fe08b16ea2c4d9867fb4974edf2a3776d6ece)
> > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251127/202511270924.0uDTpEE9-lkp@intel.com/reproduce)
> > > > 
> > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > > the same patch/commit), kindly add following tags
> > > > | Reported-by: kernel test robot <lkp@intel.com>
> > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202511270924.0uDTpEE9-lkp@intel.com/
> > > > 
> > > > All errors (new ones prefixed by >>):
> > > > 
> > > > >> drivers/clk/microchip/clk-core.c:12:10: fatal error: 'asm/traps.h' file not found
> > > >       12 | #include <asm/traps.h>
> > > >          |          ^~~~~~~~~~~~~
> > > >    1 error generated.
> > > > 
> > > > Kconfig warnings: (for reference only)
> > > >    WARNING: unmet direct dependencies detected for TSM
> > > >    Depends on [n]: VIRT_DRIVERS [=n]
> > > >    Selected by [y]:
> > > >    - PCI_TSM [=y] && PCI [=y]
> > > > 
> > > > 
> > > > vim +12 drivers/clk/microchip/clk-core.c
> > > > 
> > > > ce6e1188465998 Purna Chandra Mandal 2016-05-13 @12  #include <asm/traps.h>
> > > > ce6e1188465998 Purna Chandra Mandal 2016-05-13  13  
> > > 
> > > I only build tested this on arm64. I'll post a v2.
> > 
> > MIPS I believe is where this is used.
> 
> So looking into this further, it looks like asm/traps.h is actually not
> used by this driver, so I'll go ahead and drop that include in v2.
> 
> > Hmm, I think this is in a MAINTAINERS blind spot, Claudiu not CCed on
> > it. We should probably do something about that. Can you CC him on v2?
> 
> Yes, I'll CC Claudiu. I don't see any existing entries in MAINTAINERS
> where it looks like this driver would fit neatly.

This whole folder is kinda missing, probably there should be a
MAINTAINERS entry covering this and the at91 dir, since Claudiu usually
applies the patches for the !mips microchip stuff. That's probably
something for us to sort out though, not your responsibility!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]