From: Peter Zijlstra <peterz@infradead.org>
To: Huang Shijie <shijie@os.amperecomputing.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, patches@amperecomputing.com,
cl@linux.com, Shubhang@os.amperecomputing.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de,
linux-kernel@vger.kernel.org, vschneid@redhat.com,
vineethr@linux.ibm.com, kprateek.nayak@amd.com
Subject: Re: [PATCH v4 1/2] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle
Date: Fri, 28 Nov 2025 10:31:29 +0100 [thread overview]
Message-ID: <20251128093129.GD3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251128075454.676765-2-shijie@os.amperecomputing.com>
On Fri, Nov 28, 2025 at 03:54:53PM +0800, Huang Shijie wrote:
> Save the idle_stamp at the beginning of sched_balance_newidle(),
> if it cannot pull any task, set it for rq->idle_stamp.
>
This changelog tells me what the patch does, something I can see from
reading the patch itself. However, it completely fails at the purpose of
a changelog, which is to elucidate the reader as to the reasons for
doing so.
next prev parent reply other threads:[~2025-11-28 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 7:54 [PATCH v4 0/2] sched: update the rq->avg_idle when a task is moved to an idle CPU Huang Shijie
2025-11-28 7:54 ` [PATCH v4 1/2] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle Huang Shijie
2025-11-28 9:31 ` Peter Zijlstra [this message]
2025-12-01 2:48 ` Shijie Huang
2025-11-28 10:07 ` Madadi Vineeth Reddy
2025-11-28 12:54 ` Shijie Huang
2025-11-28 13:01 ` Shijie Huang
2025-11-28 7:54 ` [PATCH v4 2/2] sched: update the rq->avg_idle when a task is moved to an idle CPU Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128093129.GD3245006@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Shubhang@os.amperecomputing.com \
--cc=bsegall@google.com \
--cc=cl@linux.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=patches@amperecomputing.com \
--cc=rostedt@goodmis.org \
--cc=shijie@os.amperecomputing.com \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox