* [PATCH] drm/xe/pf: fix VFIO link error
@ 2025-12-04 9:41 Arnd Bergmann
2025-12-04 12:10 ` Michal Wajdeczko
2025-12-04 12:19 ` Thomas Hellström
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2025-12-04 9:41 UTC (permalink / raw)
To: Thomas Hellström, Rodrigo Vivi, David Airlie, Simona Vetter,
Michał Winiarski, Michal Wajdeczko
Cc: Arnd Bergmann, Matthew Brost, Lucas De Marchi, Jani Nikula,
Riana Tauro, intel-xe, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The Makefile logic for building xe_sriov_vfio.o was added incorrectly,
as setting CONFIG_XE_VFIO_PCI=m means it doesn't get included into a
built-in xe driver:
ERROR: modpost: "xe_sriov_vfio_stop_copy_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_stop_copy_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_suspend_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_wait_flr_done" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_resume_data_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_resume_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_resume_data_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
ERROR: modpost: "xe_sriov_vfio_migration_supported" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many)
Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide whether to
include the the object instead.
Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/xe/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
index dfc2ded01455..e5f3c2ec9e9a 100644
--- a/drivers/gpu/drm/xe/Makefile
+++ b/drivers/gpu/drm/xe/Makefile
@@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) += \
xe_sriov_pf_sysfs.o \
xe_tile_sriov_pf_debugfs.o
-ifeq ($(CONFIG_PCI_IOV),y)
- xe-$(CONFIG_XE_VFIO_PCI) += xe_sriov_vfio.o
+ifdef CONFIG_XE_VFIO_PCI
+ xe-$(CONFIG_PCI_IOV) += xe_sriov_vfio.o
endif
# include helpers for tests even when XE is built-in
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/xe/pf: fix VFIO link error
2025-12-04 9:41 [PATCH] drm/xe/pf: fix VFIO link error Arnd Bergmann
@ 2025-12-04 12:10 ` Michal Wajdeczko
2025-12-04 12:19 ` Thomas Hellström
1 sibling, 0 replies; 5+ messages in thread
From: Michal Wajdeczko @ 2025-12-04 12:10 UTC (permalink / raw)
To: Arnd Bergmann, Thomas Hellström, Rodrigo Vivi, David Airlie,
Simona Vetter, Michał Winiarski
Cc: Arnd Bergmann, Matthew Brost, Lucas De Marchi, Jani Nikula,
Riana Tauro, intel-xe, dri-devel, linux-kernel
On 12/4/2025 10:41 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The Makefile logic for building xe_sriov_vfio.o was added incorrectly,
> as setting CONFIG_XE_VFIO_PCI=m means it doesn't get included into a
> built-in xe driver:
>
> ERROR: modpost: "xe_sriov_vfio_stop_copy_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_stop_copy_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_suspend_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_wait_flr_done" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_enter" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_device" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_exit" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_migration_supported" [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> WARNING: modpost: suppressed 3 unresolved symbol warnings because there were too many)
>
> Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide whether to
> include the the object instead.
>
> Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile
> index dfc2ded01455..e5f3c2ec9e9a 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) += \
> xe_sriov_pf_sysfs.o \
> xe_tile_sriov_pf_debugfs.o
>
> -ifeq ($(CONFIG_PCI_IOV),y)
> - xe-$(CONFIG_XE_VFIO_PCI) += xe_sriov_vfio.o
> +ifdef CONFIG_XE_VFIO_PCI
> + xe-$(CONFIG_PCI_IOV) += xe_sriov_vfio.o
> endif
>
> # include helpers for tests even when XE is built-in
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/xe/pf: fix VFIO link error
2025-12-04 9:41 [PATCH] drm/xe/pf: fix VFIO link error Arnd Bergmann
2025-12-04 12:10 ` Michal Wajdeczko
@ 2025-12-04 12:19 ` Thomas Hellström
2025-12-04 13:43 ` Arnd Bergmann
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Hellström @ 2025-12-04 12:19 UTC (permalink / raw)
To: Arnd Bergmann, Rodrigo Vivi, David Airlie, Simona Vetter,
Michał Winiarski, Michal Wajdeczko
Cc: Arnd Bergmann, Matthew Brost, Lucas De Marchi, Jani Nikula,
Riana Tauro, intel-xe, dri-devel, linux-kernel
On Thu, 2025-12-04 at 10:41 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The Makefile logic for building xe_sriov_vfio.o was added
> incorrectly,
> as setting CONFIG_XE_VFIO_PCI=m means it doesn't get included into a
> built-in xe driver:
>
> ERROR: modpost: "xe_sriov_vfio_stop_copy_enter"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_stop_copy_exit"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_suspend_device"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_wait_flr_done"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_error" [drivers/vfio/pci/xe/xe-vfio-
> pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_enter"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_device"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_resume_data_exit"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_data_write" [drivers/vfio/pci/xe/xe-
> vfio-pci.ko] undefined!
> ERROR: modpost: "xe_sriov_vfio_migration_supported"
> [drivers/vfio/pci/xe/xe-vfio-pci.ko] undefined!
> WARNING: modpost: suppressed 3 unresolved symbol warnings because
> there were too many)
>
> Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide
> whether to
> include the the object instead.
s/the the/the/ found by CI.
Same question here, Do you want to resent or should I fix up when
commiting?
Thanks,
Thomas
>
> Fixes: 17f22465c5a5 ("drm/xe/pf: Export helpers for VFIO")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/xe/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/Makefile
> b/drivers/gpu/drm/xe/Makefile
> index dfc2ded01455..e5f3c2ec9e9a 100644
> --- a/drivers/gpu/drm/xe/Makefile
> +++ b/drivers/gpu/drm/xe/Makefile
> @@ -185,8 +185,8 @@ xe-$(CONFIG_PCI_IOV) += \
> xe_sriov_pf_sysfs.o \
> xe_tile_sriov_pf_debugfs.o
>
> -ifeq ($(CONFIG_PCI_IOV),y)
> - xe-$(CONFIG_XE_VFIO_PCI) += xe_sriov_vfio.o
> +ifdef CONFIG_XE_VFIO_PCI
> + xe-$(CONFIG_PCI_IOV) += xe_sriov_vfio.o
> endif
>
> # include helpers for tests even when XE is built-in
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/xe/pf: fix VFIO link error
2025-12-04 12:19 ` Thomas Hellström
@ 2025-12-04 13:43 ` Arnd Bergmann
2025-12-04 13:44 ` Thomas Hellström
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2025-12-04 13:43 UTC (permalink / raw)
To: Thomas Hellström, Arnd Bergmann, Rodrigo Vivi, Dave Airlie,
Simona Vetter, Michał Winiarski, Michal Wajdeczko
Cc: Matthew Brost, Lucas De Marchi, Jani Nikula, Riana Tauro,
intel-xe, dri-devel, linux-kernel
On Thu, Dec 4, 2025, at 13:19, Thomas Hellström wrote:
> On Thu, 2025-12-04 at 10:41 +0100, Arnd Bergmann wrote:
>>
>> Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to decide
>> whether to
>> include the the object instead.
>
> s/the the/the/ found by CI.
> Same question here, Do you want to resent or should I fix up when
> commiting?
>
I'd prefer if you can fix up both so I don't have to send it again.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/xe/pf: fix VFIO link error
2025-12-04 13:43 ` Arnd Bergmann
@ 2025-12-04 13:44 ` Thomas Hellström
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Hellström @ 2025-12-04 13:44 UTC (permalink / raw)
To: Arnd Bergmann, Arnd Bergmann, Rodrigo Vivi, Dave Airlie,
Simona Vetter, Michał Winiarski, Michal Wajdeczko
Cc: Matthew Brost, Lucas De Marchi, Jani Nikula, Riana Tauro,
intel-xe, dri-devel, linux-kernel
On Thu, 2025-12-04 at 14:43 +0100, Arnd Bergmann wrote:
> On Thu, Dec 4, 2025, at 13:19, Thomas Hellström wrote:
> > On Thu, 2025-12-04 at 10:41 +0100, Arnd Bergmann wrote:
> > >
> > > Check for CONFIG_XE_VFIO_PCI being enabled in the Makefile to
> > > decide
> > > whether to
> > > include the the object instead.
> >
> > s/the the/the/ found by CI.
> > Same question here, Do you want to resent or should I fix up when
> > commiting?
> >
>
> I'd prefer if you can fix up both so I don't have to send it again.
>
> Arnd
OK, I will.
Thanks,
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-12-04 13:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 9:41 [PATCH] drm/xe/pf: fix VFIO link error Arnd Bergmann
2025-12-04 12:10 ` Michal Wajdeczko
2025-12-04 12:19 ` Thomas Hellström
2025-12-04 13:43 ` Arnd Bergmann
2025-12-04 13:44 ` Thomas Hellström
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox