Re: [PATCH v2 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update

[Krzysztof Kozlowski <krzk@kernel.org>]

On Fri, Dec 05, 2025 at 10:55:36PM +0200, Dmitry Baryshkov wrote:
> On Thu, Dec 04, 2025 at 10:16:42AM +0530, Krishna Kurapati wrote:
> > Add squelch detect parameter update for synopsys eusb2 repeater.
> > 
> > Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> > ---
> >  .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > index 5bf0d6c9c025..f2afcf0e986a 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
> > @@ -59,6 +59,14 @@ properties:
> >      minimum: 0
> >      maximum: 7
> >  
> > +  qcom,squelch-detector-bp:
> 
> -uV? -mV?

If thi sis adjustment in ratio, then bp is correct. Some sort of
explanation in commit msg would be nice, but I don't want to stall the
patchset for that.

Assuming this is indeed ratio without actual SI units:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof