From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Johan Hovold <johan+linaro@kernel.org>,
Pengyu Luo <mitltlatltl@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update
Date: Sat, 6 Dec 2025 21:42:11 +0530 [thread overview]
Message-ID: <b772d61e-ba75-4f45-946d-211a0bb755d0@oss.qualcomm.com> (raw)
In-Reply-To: <755b7579-757f-4ced-b3c4-39c20e6b25a7@oss.qualcomm.com>
On 12/5/2025 7:01 PM, Konrad Dybcio wrote:
> On 12/4/25 5:46 AM, Krishna Kurapati wrote:
>> Add support for overriding Squelch Detect parameter.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>> .../phy/qualcomm/phy-qcom-eusb2-repeater.c | 22 +++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
>> index 651a12b59bc8..a75b37d4e16d 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c
>> @@ -37,6 +37,17 @@
>> #define EUSB2_TUNE_EUSB_EQU 0x5A
>> #define EUSB2_TUNE_EUSB_HS_COMP_CUR 0x5B
>>
>> +static const int squelch_detector[] = {
>> + [0] = -6000,
>> + [1] = -5000,
>> + [2] = -4000,
>> + [3] = -3000,
>> + [4] = -2000,
>> + [5] = -1000,
>> + [6] = 0,
>> + [7] = 1000,
>> +};
>
> I forgot to ask, do these values apply to all of the supported repeaters?
>
I checked smb2360/pmih010x_eusb2_repeater and pm8550b repeaters
(SM8{5/6/7}50/ Kaanapali/ Hamoa). For all of them, the above table is same.
Regards,
Krishna,
> i.e.
>
> PM8550B
> PMIV0104
> SMB2360
>
> Konrad
next prev parent reply other threads:[~2025-12-06 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 4:46 [PATCH v2 0/3] Add eusb2 repeater squelch detect parameter override Krishna Kurapati
2025-12-04 4:46 ` [PATCH v2 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update Krishna Kurapati
2025-12-05 20:55 ` Dmitry Baryshkov
2025-12-06 11:02 ` Krzysztof Kozlowski
2025-12-06 16:10 ` Krishna Kurapati
2025-12-09 4:36 ` Krishna Kurapati
2025-12-16 8:18 ` Krishna Kurapati
2025-12-04 4:46 ` [PATCH v2 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect " Krishna Kurapati
2025-12-05 13:31 ` Konrad Dybcio
2025-12-06 16:12 ` Krishna Kurapati [this message]
2025-12-08 12:54 ` Konrad Dybcio
2025-12-04 4:46 ` [PATCH v2 3/3] arm64: dts: qcom: sm8750-mtp: Add eusb2 repeater tuning parameters Krishna Kurapati
2025-12-04 8:55 ` Abel Vesa
2025-12-05 13:33 ` Konrad Dybcio
2025-12-06 16:09 ` Krishna Kurapati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b772d61e-ba75-4f45-946d-211a0bb755d0@oss.qualcomm.com \
--to=krishna.kurapati@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=luca.weiss@fairphone.com \
--cc=mitltlatltl@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox