From: Andrew Morton <akpm@linux-foundation.org>
To: Qiang Ma <maqianga@uniontech.com>
Cc: bhe@redhat.com, catalin.marinas@arm.com, will@kernel.org,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v1 2/3] kexec: print out debugging message if required for kexec_load
Date: Sun, 14 Dec 2025 16:32:14 -0800 [thread overview]
Message-ID: <20251214163214.5018b9c083f11c7ecc081a5d@linux-foundation.org> (raw)
In-Reply-To: <20251212095649.857796-3-maqianga@uniontech.com>
On Fri, 12 Dec 2025 17:56:48 +0800 Qiang Ma <maqianga@uniontech.com> wrote:
> The commit a85ee18c7900 ("kexec_file: print out debugging message
> if required") has added general code printing in kexec_file_load(),
> but not in kexec_load().
>
> As a result, when using '-d' for the kexec_load interface,
> print nothing in the kernel space.
That doesn't sound like a thing which "kernel test robot" would detect
and report.
> Since the segments debugging message has already been printed by the
> user-space tool kexec-tools, it will not be printed here in the
> kernel space.
>
> And print out type/start/head of kimage and flags to help debug.
>
> Signed-off-by: Qiang Ma <maqianga@uniontech.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510310332.6XrLe70K-lkp@intel.com/
Oh I see, that's a warning against an earlier version of this patch.
But this is labelled "v1"!
I suggest we remove this Reported-by record.
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -166,6 +166,9 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
> if (ret)
> goto out;
>
> + kexec_dprintk("kexec_load: type:%u, start:0x%lx head:0x%lx flags:0x%lx\n",
> + image->type, image->start, image->head, flags);
> +
> /* Install the new kernel and uninstall the old */
> image = xchg(dest_image, image);
Thanks, I'll await reviewer input before proceeding with this series.
next prev parent reply other threads:[~2025-12-15 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 9:56 [PATCH v1 0/3] kexec: add kexec flag to control debug printing Qiang Ma
2025-12-12 9:56 ` [PATCH v1 1/3] " Qiang Ma
2025-12-12 9:56 ` [PATCH v1 2/3] kexec: print out debugging message if required for kexec_load Qiang Ma
2025-12-15 0:32 ` Andrew Morton [this message]
2025-12-15 4:41 ` Qiang Ma
2025-12-12 9:56 ` [PATCH v1 3/3] arm64: kexec: Adjust the debug print of kexec_image_info Qiang Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251214163214.5018b9c083f11c7ecc081a5d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maqianga@uniontech.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).