From: Yazen Ghannam <yazen.ghannam@amd.com>
To: "Mario Limonciello (AMD)" <superm1@kernel.org>
Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, Jean Delvare <jdelvare@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h
Date: Mon, 15 Dec 2025 16:11:43 -0500 [thread overview]
Message-ID: <20251215211143.GA355290@yaz-khff2.amd.com> (raw)
In-Reply-To: <20251214185309.152614-2-superm1@kernel.org>
On Sun, Dec 14, 2025 at 12:53:05PM -0600, Mario Limonciello (AMD) wrote:
> The entries later in `enum dmi_entry_type` don't match the SMBIOS
> specification. The entry for type 33: `64-Bit Memory Error Information`
> is not present and thus the index for all later entries is incorrect.
>
> Add the missing type 33 entry.
Types 43, 44, 45, and 46 are missing also. Should those be added as
well?
Probably not needed right now, but would be good to add them in a
future patch. I think there's precedent for keeping definitions up to
date with the spec even if they're not immediately used. ACPI does
this, I think.
>
> Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers")
> Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf
> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Thanks,
Yazen
next prev parent reply other threads:[~2025-12-15 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 18:53 [PATCH 0/5] Parse SMBIOS additional entries Mario Limonciello (AMD)
2025-12-14 18:53 ` [PATCH 1/5] firmware: dmi: Correct an indexing error in dmi.h Mario Limonciello (AMD)
2025-12-15 21:11 ` Yazen Ghannam [this message]
2025-12-15 21:24 ` Mario Limonciello
2025-12-14 18:53 ` [PATCH 2/5] firmware: dmi: Adjust dmi_decode() to use enums Mario Limonciello (AMD)
2025-12-15 21:12 ` Yazen Ghannam
2025-12-14 18:53 ` [PATCH 3/5] firmware: dmi: Read additional information when decoding DMI table Mario Limonciello (AMD)
2025-12-15 4:31 ` kernel test robot
2025-12-15 5:06 ` kernel test robot
2025-12-15 12:47 ` kernel test robot
2025-12-14 18:53 ` [PATCH 4/5] firmware: dmi: Add debugfs for additional information entries Mario Limonciello (AMD)
2025-12-14 18:53 ` [PATCH 5/5] x86/amd_node: Output the AGESA version to the logs Mario Limonciello (AMD)
2025-12-15 21:23 ` Yazen Ghannam
2025-12-15 21:25 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251215211143.GA355290@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=superm1@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox