* [PATCH] node: fix a api misuse in node_init_node_access()
@ 2025-12-18 8:52 Haoxiang Li
2025-12-18 11:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Haoxiang Li @ 2025-12-18 8:52 UTC (permalink / raw)
To: gregkh, rafael, dakr, Jonathan.Cameron, kbusch
Cc: linux-kernel, Haoxiang Li, stable
If device_register() fails, put_device() is the correct way to
cleanup the resource.
And free the dev name is unnecessary.
Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
drivers/base/node.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c
index 00cf4532f121..28c89ad67d0b 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -170,14 +170,15 @@ static struct node_access_nodes *node_init_node_access(struct node *node,
if (dev_set_name(dev, "access%u", access))
goto free;
- if (device_register(dev))
- goto free_name;
+ if (device_register(dev)) {
+ put_device(dev);
+ return NULL;
+ }
pm_runtime_no_callbacks(dev);
list_add_tail(&access_node->list_node, &node->access_list);
return access_node;
-free_name:
- kfree_const(dev->kobj.name);
+
free:
kfree(access_node);
return NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] node: fix a api misuse in node_init_node_access()
2025-12-18 8:52 [PATCH] node: fix a api misuse in node_init_node_access() Haoxiang Li
@ 2025-12-18 11:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-12-18 11:23 UTC (permalink / raw)
To: Haoxiang Li; +Cc: rafael, dakr, Jonathan.Cameron, kbusch, linux-kernel, stable
On Thu, Dec 18, 2025 at 04:52:51PM +0800, Haoxiang Li wrote:
> If device_register() fails, put_device() is the correct way to
> cleanup the resource.
> And free the dev name is unnecessary.
>
> Fixes: 08d9dbe72b1f ("node: Link memory nodes to their compute nodes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
> ---
> drivers/base/node.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 00cf4532f121..28c89ad67d0b 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -170,14 +170,15 @@ static struct node_access_nodes *node_init_node_access(struct node *node,
> if (dev_set_name(dev, "access%u", access))
> goto free;
>
> - if (device_register(dev))
> - goto free_name;
> + if (device_register(dev)) {
> + put_device(dev);
> + return NULL;
> + }
>
> pm_runtime_no_callbacks(dev);
> list_add_tail(&access_node->list_node, &node->access_list);
> return access_node;
> -free_name:
> - kfree_const(dev->kobj.name);
> +
> free:
> kfree(access_node);
> return NULL;
> --
> 2.25.1
>
>
How was this found and tested?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-18 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-18 8:52 [PATCH] node: fix a api misuse in node_init_node_access() Haoxiang Li
2025-12-18 11:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox