The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
@ 2025-12-03 12:51 Biju
  2025-12-05 11:59 ` Steven Price
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Biju @ 2025-12-03 12:51 UTC (permalink / raw)
  To: Boris Brezillon, Rob Herring, Steven Price, Adrián Larumbe,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Geert Uytterhoeven, Magnus Damm
  Cc: Biju Das, dri-devel, linux-kernel, linux-renesas-soc,
	Prabhakar Mahadev Lad, Biju Das

From: Biju Das <biju.das.jz@bp.renesas.com>

RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs after
STR in the following condition:

STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.

Fix this issue by asserting/deasserting the reset during suspend/resume.
Rename the variable allwinner_h616_data->default_pm_rt_data for data
reuse and make it as generic GPU PM runtime data.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
index 7d8c7c337606..e553f183c780 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
 	.pm_domain_names = NULL,
 };
 
-static const struct panfrost_compatible allwinner_h616_data = {
+static const struct panfrost_compatible default_pm_rt_data = {
 	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
 	.supply_names = default_supplies,
 	.num_pm_domains = 1,
@@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
 	  .data = &amlogic_data, },
 	{ .compatible = "amlogic,meson-g12a-mali",
 	  .data = &amlogic_data, },
+	{ .compatible = "renesas,r9a09g047-mali", .data = &default_pm_rt_data },
 	{ .compatible = "arm,mali-t604", .data = &default_data, },
 	{ .compatible = "arm,mali-t624", .data = &default_data, },
 	{ .compatible = "arm,mali-t628", .data = &default_data, },
@@ -1073,7 +1074,7 @@ static const struct of_device_id dt_match[] = {
 	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
 	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
 	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
-	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
+	{ .compatible = "allwinner,sun50i-h616-mali", .data = &default_pm_rt_data },
 	{}
 };
 MODULE_DEVICE_TABLE(of, dt_match);
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-03 12:51 [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC Biju
@ 2025-12-05 11:59 ` Steven Price
  2025-12-19  9:49 ` Biju Das
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 9+ messages in thread
From: Steven Price @ 2025-12-05 11:59 UTC (permalink / raw)
  To: Biju, Boris Brezillon, Rob Herring, Adrián Larumbe,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Geert Uytterhoeven, Magnus Damm
  Cc: Biju Das, dri-devel, linux-kernel, linux-renesas-soc,
	Prabhakar Mahadev Lad

On 03/12/2025 12:51, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs after
> STR in the following condition:
> 
> STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.
> 
> Fix this issue by asserting/deasserting the reset during suspend/resume.
> Rename the variable allwinner_h616_data->default_pm_rt_data for data
> reuse and make it as generic GPU PM runtime data.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Steven Price <steven.price@arm.com>

> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 7d8c7c337606..e553f183c780 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
>  	.pm_domain_names = NULL,
>  };
>  
> -static const struct panfrost_compatible allwinner_h616_data = {
> +static const struct panfrost_compatible default_pm_rt_data = {
>  	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
>  	.supply_names = default_supplies,
>  	.num_pm_domains = 1,
> @@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
>  	  .data = &amlogic_data, },
>  	{ .compatible = "amlogic,meson-g12a-mali",
>  	  .data = &amlogic_data, },
> +	{ .compatible = "renesas,r9a09g047-mali", .data = &default_pm_rt_data },
>  	{ .compatible = "arm,mali-t604", .data = &default_data, },
>  	{ .compatible = "arm,mali-t624", .data = &default_data, },
>  	{ .compatible = "arm,mali-t628", .data = &default_data, },
> @@ -1073,7 +1074,7 @@ static const struct of_device_id dt_match[] = {
>  	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
>  	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
>  	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
> -	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
> +	{ .compatible = "allwinner,sun50i-h616-mali", .data = &default_pm_rt_data },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, dt_match);


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-03 12:51 [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC Biju
  2025-12-05 11:59 ` Steven Price
@ 2025-12-19  9:49 ` Biju Das
  2025-12-19 10:01   ` Adrián Larumbe
  2025-12-21  1:07 ` Adrián Larumbe
  2025-12-21  1:41 ` Adrián Larumbe
  3 siblings, 1 reply; 9+ messages in thread
From: Biju Das @ 2025-12-19  9:49 UTC (permalink / raw)
  To: biju.das.au, Boris Brezillon, Rob Herring, Steven Price,
	Adrián Larumbe, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter,
	Geert Uytterhoeven, magnus.damm
  Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, Prabhakar Mahadev Lad,
	biju.das.au

Hi All,

> -----Original Message-----
> From: Biju <biju.das.au@gmail.com>
> Sent: 03 December 2025 12:51
> Subject: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
> 
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs after STR in the following
> condition:
> 
> STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.
> 
> Fix this issue by asserting/deasserting the reset during suspend/resume.
> Rename the variable allwinner_h616_data->default_pm_rt_data for data reuse and make it as generic GPU
> PM runtime data.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 7d8c7c337606..e553f183c780 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
>  	.pm_domain_names = NULL,
>  };
> 
> -static const struct panfrost_compatible allwinner_h616_data = {
> +static const struct panfrost_compatible default_pm_rt_data = {
>  	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
>  	.supply_names = default_supplies,
>  	.num_pm_domains = 1,
> @@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
>  	  .data = &amlogic_data, },
>  	{ .compatible = "amlogic,meson-g12a-mali",
>  	  .data = &amlogic_data, },
> +	{ .compatible = "renesas,r9a09g047-mali", .data = &default_pm_rt_data
> +},
>  	{ .compatible = "arm,mali-t604", .data = &default_data, },
>  	{ .compatible = "arm,mali-t624", .data = &default_data, },
>  	{ .compatible = "arm,mali-t628", .data = &default_data, }, @@ -1073,7 +1074,7 @@ static const
> struct of_device_id dt_match[] = {
>  	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
>  	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
>  	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
> -	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
> +	{ .compatible = "allwinner,sun50i-h616-mali", .data =
> +&default_pm_rt_data },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, dt_match);
> --
> 2.43.0

Gentle ping.

Cheers,
Biju


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-19  9:49 ` Biju Das
@ 2025-12-19 10:01   ` Adrián Larumbe
  2025-12-19 10:13     ` Biju Das
  0 siblings, 1 reply; 9+ messages in thread
From: Adrián Larumbe @ 2025-12-19 10:01 UTC (permalink / raw)
  To: Biju Das
  Cc: biju.das.au, Boris Brezillon, Rob Herring, Steven Price,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Geert Uytterhoeven, magnus.damm,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, Prabhakar Mahadev Lad

Hi Biju,

I'll be merging your patch. It'll be my first time as a Panfrost maintainer, so bear me with me
while I become familiar with the process.

Kind Regards,
Adrian

On 19.12.2025 09:49, Biju Das wrote:
> Hi All,
>
> > -----Original Message-----
> > From: Biju <biju.das.au@gmail.com>
> > Sent: 03 December 2025 12:51
> > Subject: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
> >
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs after STR in the following
> > condition:
> >
> > STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.
> >
> > Fix this issue by asserting/deasserting the reset during suspend/resume.
> > Rename the variable allwinner_h616_data->default_pm_rt_data for data reuse and make it as generic GPU
> > PM runtime data.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> >  drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> > index 7d8c7c337606..e553f183c780 100644
> > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> > @@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
> >  	.pm_domain_names = NULL,
> >  };
> >
> > -static const struct panfrost_compatible allwinner_h616_data = {
> > +static const struct panfrost_compatible default_pm_rt_data = {
> >  	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
> >  	.supply_names = default_supplies,
> >  	.num_pm_domains = 1,
> > @@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
> >  	  .data = &amlogic_data, },
> >  	{ .compatible = "amlogic,meson-g12a-mali",
> >  	  .data = &amlogic_data, },
> > +	{ .compatible = "renesas,r9a09g047-mali", .data = &default_pm_rt_data
> > +},
> >  	{ .compatible = "arm,mali-t604", .data = &default_data, },
> >  	{ .compatible = "arm,mali-t624", .data = &default_data, },
> >  	{ .compatible = "arm,mali-t628", .data = &default_data, }, @@ -1073,7 +1074,7 @@ static const
> > struct of_device_id dt_match[] = {
> >  	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
> >  	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
> >  	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
> > -	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
> > +	{ .compatible = "allwinner,sun50i-h616-mali", .data =
> > +&default_pm_rt_data },
> >  	{}
> >  };
> >  MODULE_DEVICE_TABLE(of, dt_match);
> > --
> > 2.43.0
>
> Gentle ping.
>
> Cheers,
> Biju

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-19 10:01   ` Adrián Larumbe
@ 2025-12-19 10:13     ` Biju Das
  2025-12-19 11:04       ` Boris Brezillon
  0 siblings, 1 reply; 9+ messages in thread
From: Biju Das @ 2025-12-19 10:13 UTC (permalink / raw)
  To: Adrián Larumbe
  Cc: biju.das.au, Boris Brezillon, Rob Herring, Steven Price,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Geert Uytterhoeven, magnus.damm,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, Prabhakar Mahadev Lad

Hi Adrián Larumbe,

> -----Original Message-----
> From: Adrián Larumbe <adrian.larumbe@collabora.com>
> Sent: 19 December 2025 10:02
> Subject: Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
> 
> Hi Biju,
> 
> I'll be merging your patch. It'll be my first time as a Panfrost maintainer, so bear me with me while
> I become familiar with the process.

OK. Thanks.

FYI, I just use the below 4 commands based on the documentation to merge a patch after the initial dim setup.

=> ./maintainer-tools/dim update-branches
=> ./maintainer-tools/dim checkout drm-misc-next
=> curl xxx | ./maintainer-tools/dim apply-branch drm-misc-next
=> ./maintainer-tools/dim push-branch drm-misc-next

Cheers,
Biju

> 
> Kind Regards,
> Adrian
> 
> On 19.12.2025 09:49, Biju Das wrote:
> > Hi All,
> >
> > > -----Original Message-----
> > > From: Biju <biju.das.au@gmail.com>
> > > Sent: 03 December 2025 12:51
> > > Subject: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
> > >
> > > From: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs
> > > after STR in the following
> > > condition:
> > >
> > > STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.
> > >
> > > Fix this issue by asserting/deasserting the reset during suspend/resume.
> > > Rename the variable allwinner_h616_data->default_pm_rt_data for data
> > > reuse and make it as generic GPU PM runtime data.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > ---
> > >  drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c
> > > b/drivers/gpu/drm/panfrost/panfrost_drv.c
> > > index 7d8c7c337606..e553f183c780 100644
> > > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> > > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> > > @@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
> > >  	.pm_domain_names = NULL,
> > >  };
> > >
> > > -static const struct panfrost_compatible allwinner_h616_data = {
> > > +static const struct panfrost_compatible default_pm_rt_data = {
> > >  	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
> > >  	.supply_names = default_supplies,
> > >  	.num_pm_domains = 1,
> > > @@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
> > >  	  .data = &amlogic_data, },
> > >  	{ .compatible = "amlogic,meson-g12a-mali",
> > >  	  .data = &amlogic_data, },
> > > +	{ .compatible = "renesas,r9a09g047-mali", .data =
> > > +&default_pm_rt_data },
> > >  	{ .compatible = "arm,mali-t604", .data = &default_data, },
> > >  	{ .compatible = "arm,mali-t624", .data = &default_data, },
> > >  	{ .compatible = "arm,mali-t628", .data = &default_data, }, @@
> > > -1073,7 +1074,7 @@ static const struct of_device_id dt_match[] = {
> > >  	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
> > >  	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
> > >  	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
> > > -	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
> > > +	{ .compatible = "allwinner,sun50i-h616-mali", .data =
> > > +&default_pm_rt_data },
> > >  	{}
> > >  };
> > >  MODULE_DEVICE_TABLE(of, dt_match);
> > > --
> > > 2.43.0
> >
> > Gentle ping.
> >
> > Cheers,
> > Biju

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-19 10:13     ` Biju Das
@ 2025-12-19 11:04       ` Boris Brezillon
  2025-12-19 15:50         ` Biju Das
  0 siblings, 1 reply; 9+ messages in thread
From: Boris Brezillon @ 2025-12-19 11:04 UTC (permalink / raw)
  To: Biju Das
  Cc: Adrián Larumbe, biju.das.au, Rob Herring, Steven Price,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Geert Uytterhoeven, magnus.damm,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, Prabhakar Mahadev Lad

On Fri, 19 Dec 2025 10:13:45 +0000
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> Hi Adrián Larumbe,
> 
> > -----Original Message-----
> > From: Adrián Larumbe <adrian.larumbe@collabora.com>
> > Sent: 19 December 2025 10:02
> > Subject: Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
> > 
> > Hi Biju,
> > 
> > I'll be merging your patch. It'll be my first time as a Panfrost maintainer, so bear me with me while
> > I become familiar with the process.  
> 
> OK. Thanks.
> 
> FYI, I just use the below 4 commands based on the documentation to merge a patch after the initial dim setup.
> 
> => ./maintainer-tools/dim update-branches
> => ./maintainer-tools/dim checkout drm-misc-next
> => curl xxx | ./maintainer-tools/dim apply-branch drm-misc-next

Or

# dim b4-shazam 20251203125104.67596-1-biju.das.jz@bp.renesas.com

if you find it simpler to pass a get the Message-ID than searching
for a link to pass to curl.

> => ./maintainer-tools/dim push-branch drm-misc-next  

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-19 11:04       ` Boris Brezillon
@ 2025-12-19 15:50         ` Biju Das
  0 siblings, 0 replies; 9+ messages in thread
From: Biju Das @ 2025-12-19 15:50 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Adrián Larumbe, biju.das.au, Rob Herring, Steven Price,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Simona Vetter, Geert Uytterhoeven, magnus.damm,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org, Prabhakar Mahadev Lad

Hi Boris Brezillon,

> -----Original Message-----
> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Boris Brezillon
> Sent: 19 December 2025 11:04
> Subject: Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
> 
> On Fri, 19 Dec 2025 10:13:45 +0000
> Biju Das <biju.das.jz@bp.renesas.com> wrote:
> 
> > Hi Adrián Larumbe,
> >
> > > -----Original Message-----
> > > From: Adrián Larumbe <adrian.larumbe@collabora.com>
> > > Sent: 19 December 2025 10:02
> > > Subject: Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E
> > > SoC
> > >
> > > Hi Biju,
> > >
> > > I'll be merging your patch. It'll be my first time as a Panfrost
> > > maintainer, so bear me with me while I become familiar with the process.
> >
> > OK. Thanks.
> >
> > FYI, I just use the below 4 commands based on the documentation to merge a patch after the initial
> dim setup.
> >
> > => ./maintainer-tools/dim update-branches => ./maintainer-tools/dim
> > checkout drm-misc-next => curl xxx | ./maintainer-tools/dim
> > apply-branch drm-misc-next
> 
> Or
> 
> # dim b4-shazam 20251203125104.67596-1-biju.das.jz@bp.renesas.com
> 
> if you find it simpler to pass a get the Message-ID than searching for a link to pass to curl.

Thank you for the info.

Cheers,
Biju

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-03 12:51 [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC Biju
  2025-12-05 11:59 ` Steven Price
  2025-12-19  9:49 ` Biju Das
@ 2025-12-21  1:07 ` Adrián Larumbe
  2025-12-21  1:41 ` Adrián Larumbe
  3 siblings, 0 replies; 9+ messages in thread
From: Adrián Larumbe @ 2025-12-21  1:07 UTC (permalink / raw)
  To: Biju
  Cc: Boris Brezillon, Rob Herring, Steven Price, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
	Geert Uytterhoeven, Magnus Damm, Biju Das, dri-devel,
	linux-kernel, linux-renesas-soc, Prabhakar Mahadev Lad

Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>

On 03.12.2025 12:51, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs after
> STR in the following condition:
>
> STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.
>
> Fix this issue by asserting/deasserting the reset during suspend/resume.
> Rename the variable allwinner_h616_data->default_pm_rt_data for data
> reuse and make it as generic GPU PM runtime data.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 7d8c7c337606..e553f183c780 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
>  	.pm_domain_names = NULL,
>  };
>
> -static const struct panfrost_compatible allwinner_h616_data = {
> +static const struct panfrost_compatible default_pm_rt_data = {
>  	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
>  	.supply_names = default_supplies,
>  	.num_pm_domains = 1,
> @@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
>  	  .data = &amlogic_data, },
>  	{ .compatible = "amlogic,meson-g12a-mali",
>  	  .data = &amlogic_data, },
> +	{ .compatible = "renesas,r9a09g047-mali", .data = &default_pm_rt_data },
>  	{ .compatible = "arm,mali-t604", .data = &default_data, },
>  	{ .compatible = "arm,mali-t624", .data = &default_data, },
>  	{ .compatible = "arm,mali-t628", .data = &default_data, },
> @@ -1073,7 +1074,7 @@ static const struct of_device_id dt_match[] = {
>  	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
>  	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
>  	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
> -	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
> +	{ .compatible = "allwinner,sun50i-h616-mali", .data = &default_pm_rt_data },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, dt_match);
> --
> 2.43.0

Adrian Larumbe

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC
  2025-12-03 12:51 [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC Biju
                   ` (2 preceding siblings ...)
  2025-12-21  1:07 ` Adrián Larumbe
@ 2025-12-21  1:41 ` Adrián Larumbe
  3 siblings, 0 replies; 9+ messages in thread
From: Adrián Larumbe @ 2025-12-21  1:41 UTC (permalink / raw)
  To: Biju
  Cc: Boris Brezillon, Rob Herring, Steven Price, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
	Geert Uytterhoeven, Magnus Damm, Biju Das, dri-devel,
	linux-kernel, linux-renesas-soc, Prabhakar Mahadev Lad

On 03.12.2025 12:51, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> RZ/G3E SoC is embedded with Mali-G52 GPU system. The system hangs after
> STR in the following condition:
>
> STR -> Wakeup from STR -> Unload panfrost using 'modprobe -r panfrost'.
>
> Fix this issue by asserting/deasserting the reset during suspend/resume.
> Rename the variable allwinner_h616_data->default_pm_rt_data for data
> reuse and make it as generic GPU PM runtime data.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 7d8c7c337606..e553f183c780 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -976,7 +976,7 @@ static const struct panfrost_compatible default_data = {
>  	.pm_domain_names = NULL,
>  };
>
> -static const struct panfrost_compatible allwinner_h616_data = {
> +static const struct panfrost_compatible default_pm_rt_data = {
>  	.num_supplies = ARRAY_SIZE(default_supplies) - 1,
>  	.supply_names = default_supplies,
>  	.num_pm_domains = 1,
> @@ -1056,6 +1056,7 @@ static const struct of_device_id dt_match[] = {
>  	  .data = &amlogic_data, },
>  	{ .compatible = "amlogic,meson-g12a-mali",
>  	  .data = &amlogic_data, },
> +	{ .compatible = "renesas,r9a09g047-mali", .data = &default_pm_rt_data },
>  	{ .compatible = "arm,mali-t604", .data = &default_data, },
>  	{ .compatible = "arm,mali-t624", .data = &default_data, },
>  	{ .compatible = "arm,mali-t628", .data = &default_data, },
> @@ -1073,7 +1074,7 @@ static const struct of_device_id dt_match[] = {
>  	{ .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
>  	{ .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
>  	{ .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
> -	{ .compatible = "allwinner,sun50i-h616-mali", .data = &allwinner_h616_data },
> +	{ .compatible = "allwinner,sun50i-h616-mali", .data = &default_pm_rt_data },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, dt_match);
> --
> 2.43.0

Queued to drm-misc-next.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-12-21  1:41 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-03 12:51 [PATCH] drm/panfrost: Add GPU_PM_RT support for RZ/G3E SoC Biju
2025-12-05 11:59 ` Steven Price
2025-12-19  9:49 ` Biju Das
2025-12-19 10:01   ` Adrián Larumbe
2025-12-19 10:13     ` Biju Das
2025-12-19 11:04       ` Boris Brezillon
2025-12-19 15:50         ` Biju Das
2025-12-21  1:07 ` Adrián Larumbe
2025-12-21  1:41 ` Adrián Larumbe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox