public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Mario Limonciello <superm1@kernel.org>, <x86@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/7] firmware: dmi: Read additional information when decoding DMI table
Date: Mon, 22 Dec 2025 17:59:45 +0100	[thread overview]
Message-ID: <20251222175945.59c76f67@endymion> (raw)
In-Reply-To: <20251217212134.GD1263950@yaz-khff2.amd.com>

Hi Yazen, Mario,

On Wed, 17 Dec 2025 16:21:34 -0500, Yazen Ghannam wrote:
> On Wed, Dec 17, 2025 at 03:09:33PM -0600, Mario Limonciello wrote:
> > On 12/17/25 3:03 PM, Yazen Ghannam wrote:  
> > > On Tue, Dec 16, 2025 at 06:33:50AM -0600, Mario Limonciello (AMD) wrote:  
> > > > Type 40 entries (Additional information) are summarized in section
> > > > 7.41 as part of the SMBIOS specification.  Save these entries when
> > > > decoding the DMI tables.
> > > 
> > > Why can't an interested user just use dmidecode?
> > 
> > They could.  The reason for doing it in this series is the same reason for
> > the one that we did the S5 bit.
> > 
> > It shows up in the logs, you can tie regressions to the AGESA version at
> > specifically at the time of the failure if they've done BIOS updates since
> > then.  
> 
> Yes, right. Sorry, I mixed this up with the debugfs patch.
> 
> We need to save it here so the init code can find it.
> 
> But why do we need a debugfs entry for it?

FWIW, I had the exact same feeling when first gazing at this patch
series. I believe that every problem that can be solved in user-space
should be solved in user-space. Now I get the reason (explained above)
for logging the information at boot time, and thus the requirement to
parse type 40 in the kernel, but if there's no strong reason to have a
debugfs interface then I'd just drop it.

Of course, we also want to improve support for type 40 in dmidecode. I
admit I didn't pay too much attention to it so far due to a lack of use
case. But now that there's a use case, I'll be happy to work on it (or
commit a contribution if someone else beats me to it).

-- 
Jean Delvare
SUSE L3 Support

  parent reply	other threads:[~2025-12-22 16:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 12:33 [PATCH v2 0/7] Parse SMBIOS additional entries Mario Limonciello (AMD)
2025-12-16 12:33 ` [PATCH v2 1/7] firmware: dmi: Correct an indexing error in dmi.h Mario Limonciello (AMD)
2025-12-22 16:48   ` Jean Delvare
2025-12-16 12:33 ` [PATCH v2 2/7] firmware: dmi: Adjust dmi_decode() to use enums Mario Limonciello (AMD)
2025-12-22 16:50   ` Jean Delvare
2025-12-16 12:33 ` [PATCH v2 3/7] firmware: dmi: Read additional information when decoding DMI table Mario Limonciello (AMD)
2025-12-17 21:03   ` Yazen Ghannam
2025-12-17 21:09     ` Mario Limonciello
2025-12-17 21:21       ` Yazen Ghannam
2025-12-17 21:23         ` Mario Limonciello
2025-12-18 15:43           ` Yazen Ghannam
2025-12-22 16:59         ` Jean Delvare [this message]
2025-12-22 17:51   ` Jean Delvare
2025-12-22 21:31   ` Jean DELVARE
2025-12-16 12:33 ` [PATCH v2 4/7] firmware: dmi: Add debugfs for additional information entries Mario Limonciello (AMD)
2025-12-16 12:33 ` [PATCH v2 5/7] firmware: dmi: Add missing DMI entry types Mario Limonciello (AMD)
2025-12-22 17:01   ` Jean Delvare
2025-12-16 12:33 ` [PATCH v2 6/7] x86/CPU/AMD: Prefix messages with x86/amd Mario Limonciello (AMD)
2025-12-17 21:10   ` Yazen Ghannam
2025-12-16 12:33 ` [PATCH v2 7/7] x86/CPU/AMD: Output the AGESA version to the logs Mario Limonciello (AMD)
2025-12-17 21:18   ` Yazen Ghannam
2025-12-17 21:21     ` Mario Limonciello
2025-12-18 15:47       ` Yazen Ghannam
2025-12-22 18:18   ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251222175945.59c76f67@endymion \
    --to=jdelvare@suse.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=superm1@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox