From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: dt-bindings: Add qcom,sm6150-camss
Date: Tue, 23 Dec 2025 14:38:17 +0100 [thread overview]
Message-ID: <20251223-pompous-inescapable-sponge-3fc9f0@quoll> (raw)
In-Reply-To: <20251222-sm6150-camss-v2-1-df8469a8343a@oss.qualcomm.com>
On Mon, Dec 22, 2025 at 04:28:39PM +0800, Wenmeng Liu wrote:
> + interconnects:
> + maxItems: 4
> +
> + interconnect-names:
> + items:
> + - const: ahb
> + - const: hf0_mnoc
> + - const: hf1_mnoc
Same comments as before, do not invent names.
I finish review here and ignore the rest. You did not respond to
previous comments and I do not see any improvements.
Also, way you send patches makes it difficult for us, so I see no reason
why it should be my task to try to decipher all this.
b4 diff '20251222-sm6150-camss-v2-1-df8469a8343a@oss.qualcomm.com'
Checking for older revisions
Grabbing search results from lore.kernel.org
---
Analyzing 5 messages in the thread
Could not find lower series to compare against.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-23 13:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 8:28 [PATCH v2 0/3] media: qcom: camss: Add sm6150 camss support Wenmeng Liu
2025-12-22 8:28 ` [PATCH v2 1/3] media: dt-bindings: Add qcom,sm6150-camss Wenmeng Liu
2025-12-23 13:38 ` Krzysztof Kozlowski [this message]
2025-12-24 3:18 ` Wenmeng Liu
2025-12-24 4:21 ` Dmitry Baryshkov
2025-12-24 4:31 ` Wenmeng Liu
2025-12-24 5:03 ` Dmitry Baryshkov
2025-12-24 5:36 ` Wenmeng Liu
2025-12-24 6:20 ` Dmitry Baryshkov
2025-12-24 9:46 ` Krzysztof Kozlowski
2025-12-24 10:29 ` Wenmeng Liu
2025-12-24 12:24 ` Dmitry Baryshkov
2025-12-24 9:43 ` Krzysztof Kozlowski
2025-12-22 8:28 ` [PATCH v2 2/3] media: qcom: camss: add support for SM6150 camss Wenmeng Liu
2026-01-12 0:34 ` Bryan O'Donoghue
2026-01-12 8:12 ` Wenmeng Liu
2025-12-22 8:28 ` [PATCH v2 3/3] arm64: dts: qcom: talos: Add camss node Wenmeng Liu
2025-12-23 13:35 ` [PATCH v2 0/3] media: qcom: camss: Add sm6150 camss support Krzysztof Kozlowski
2025-12-24 3:25 ` Wenmeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251223-pompous-inescapable-sponge-3fc9f0@quoll \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox