Re: [PATCH v2 1/3] media: dt-bindings: Add qcom,sm6150-camss

[Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>]

On 12/23/2025 9:38 PM, Krzysztof Kozlowski wrote:
> On Mon, Dec 22, 2025 at 04:28:39PM +0800, Wenmeng Liu wrote:
>> +  interconnects:
>> +    maxItems: 4
>> +
>> +  interconnect-names:
>> +    items:
>> +      - const: ahb
>> +      - const: hf0_mnoc
>> +      - const: hf1_mnoc
> 
> Same comments as before, do not invent names.

<&mmss_noc MASTER_CAMNOC_HF0 QCOM_ICC_TAG_ALWAYS
&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
<&mmss_noc MASTER_CAMNOC_HF1 QCOM_ICC_TAG_ALWAYS
&mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,

This platform(qcs615) is different from others. It has two types of sf, 
namely sf0 and sf1.
The same as it is:
sc7180 sc8180x sdm670 sdm845 sm8150
Do you have any suggestions about this?

> 
> I finish review here and ignore the rest. You did not respond to
> previous comments and I do not see any improvements.

I'm sorry about this. However, the previous comments did not clearly 
point out the problem.

> Also, way you send patches makes it difficult for us, so I see no reason
> why it should be my task to try to decipher all this.
> 
> b4 diff '20251222-sm6150-camss-v2-1-df8469a8343a@oss.qualcomm.com'
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> ---
> Analyzing 5 messages in the thread
> Could not find lower series to compare against.

--in-reply-to, will pay attention in the next version.

Thanks,Wenmeng