* [PATCH] drm/bridge: synopsys: dw-dp: Pass dp->irq instead of ret to ERR_PTR() on IRQ failure
@ 2025-12-26 7:20 Alper Ak
2025-12-26 8:13 ` Andy Yan
0 siblings, 1 reply; 2+ messages in thread
From: Alper Ak @ 2025-12-26 7:20 UTC (permalink / raw)
To: andy.yan
Cc: Alper Ak, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, dri-devel, linux-kernel
The error handling after platform_get_irq() incorrectly passes ret to
ERR_PTR(), but ret still holds the value 0 from the previous successful
devm_add_action_or_reset() call. This causes ERR_PTR(0) which returns NULL
instead of a proper error pointer.
Pass dp->irq to ERR_PTR() since platform_get_irq() returns the negative
error code directly in dp->irq on failure.
Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 36382956bbe0..718397a29e80 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -2079,7 +2079,7 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
dp->irq = platform_get_irq(pdev, 0);
if (dp->irq < 0)
- return ERR_PTR(ret);
+ return ERR_PTR(dp->irq);
ret = devm_request_threaded_irq(dev, dp->irq, NULL, dw_dp_irq,
IRQF_ONESHOT, dev_name(dev), dp);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re:[PATCH] drm/bridge: synopsys: dw-dp: Pass dp->irq instead of ret to ERR_PTR() on IRQ failure
2025-12-26 7:20 [PATCH] drm/bridge: synopsys: dw-dp: Pass dp->irq instead of ret to ERR_PTR() on IRQ failure Alper Ak
@ 2025-12-26 8:13 ` Andy Yan
0 siblings, 0 replies; 2+ messages in thread
From: Andy Yan @ 2025-12-26 8:13 UTC (permalink / raw)
To: Alper Ak
Cc: andy.yan, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, dri-devel, linux-kernel
Hello Alper，
At 2025-12-26 15:20:01, "Alper Ak" <alperyasinak1@gmail.com> wrote:
>The error handling after platform_get_irq() incorrectly passes ret to
>ERR_PTR(), but ret still holds the value 0 from the previous successful
>devm_add_action_or_reset() call. This causes ERR_PTR(0) which returns NULL
>instead of a proper error pointer.
>
>Pass dp->irq to ERR_PTR() since platform_get_irq() returns the negative
>error code directly in dp->irq on failure.
>
>Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
>Signed-off-by: Alper Ak <alperyasinak1@gmail.com>
Reviewed-by: Andy Yan <andyshrk@163.com>
Thanks
>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 36382956bbe0..718397a29e80 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -2079,7 +2079,7 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
>
> dp->irq = platform_get_irq(pdev, 0);
> if (dp->irq < 0)
>- return ERR_PTR(ret);
>+ return ERR_PTR(dp->irq);
>
> ret = devm_request_threaded_irq(dev, dp->irq, NULL, dw_dp_irq,
> IRQF_ONESHOT, dev_name(dev), dp);
>--
>2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-26 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 7:20 [PATCH] drm/bridge: synopsys: dw-dp: Pass dp->irq instead of ret to ERR_PTR() on IRQ failure Alper Ak
2025-12-26 8:13 ` Andy Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox