public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Christian Brauner <brauner@kernel.org>,
	 Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
	 Steve French <sfrench@samba.org>,
	Paulo Alcantara <pc@manguebit.org>,
	 Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	 Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>,
	 Bharath SM <bharathsm@microsoft.com>,
	Trond Myklebust <trondmy@kernel.org>,
	 Anna Schumaker <anna@kernel.org>,
	Eric Van Hensbergen <ericvh@kernel.org>,
	 Latchesar Ionkov <lucho@ionkov.net>,
	 Dominique Martinet <asmadeus@codewreck.org>,
	 Christian Schoenebeck <linux_oss@crudebyte.com>,
	 Andreas Gruenbacher <agruenba@redhat.com>,
	Xiubo Li <xiubli@redhat.com>,  Ilya Dryomov <idryomov@gmail.com>,
	Hans de Goede <hansg@kernel.org>,  NeilBrown <neil@brown.name>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-cifs@vger.kernel.org,  samba-technical@lists.samba.org,
	linux-kernel@vger.kernel.org,  linux-nfs@vger.kernel.org,
	v9fs@lists.linux.dev, gfs2@lists.linux.dev,
	 ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	 Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 0/6] vfs: properly deny directory leases on filesystems with special lease handling
Date: Wed, 07 Jan 2026 09:20:08 -0500	[thread overview]
Message-ID: <20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org> (raw)

Filesystems currently have to set the ->setlease() method explicitly in
order to deny attempts to set a lease or delegation. With the advent of
directory delegations, we now need to set ->setlease on the directory
file_operations for several filesystems to simple_nosetlease() to ensure
this.

This patchset does that. There should be no noticeable change in
behavior, other than fixing the support detection in xfstests, allowing
lease/delegation tests to be properly skipped on these filesystems.

It's probably simplest to merge these all at once via Christian's tree
if he's amenable, but Acks would be welcome. Ideally these would go in
for v6.19.

Long term, I think it would be best to change leases/delegations to be
an opt-in thing, such that leases are always denied by default if the
method isn't set. That's a larger patchset though as we'd need to audit
all of the file_operations that currently have ->setlease() as NULL.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (6):
      nfs: properly disallow delegation requests on directories
      smb/client: properly disallow delegations on directories
      9p: don't allow delegations to be set on directories
      gfs2: don't allow delegations to be set on directories
      ceph: don't allow delegations to be set on directories
      vboxsf: don't allow delegations to be set on directories

 fs/9p/vfs_dir.c        | 2 ++
 fs/ceph/dir.c          | 2 ++
 fs/gfs2/file.c         | 1 +
 fs/nfs/dir.c           | 1 +
 fs/nfs/nfs4file.c      | 2 --
 fs/smb/client/cifsfs.c | 4 +---
 fs/vboxsf/dir.c        | 1 +
 7 files changed, 8 insertions(+), 5 deletions(-)
---
base-commit: 7f98ab9da046865d57c102fd3ca9669a29845f67
change-id: 20260107-setlease-6-19-3ab7a5d30c51

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


             reply	other threads:[~2026-01-07 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07 14:20 Jeff Layton [this message]
2026-01-07 14:20 ` [PATCH 1/6] nfs: properly disallow delegation requests on directories Jeff Layton
2026-01-08  9:24   ` Christoph Hellwig
2026-01-07 14:20 ` [PATCH 2/6] smb/client: properly disallow delegations " Jeff Layton
2026-01-07 14:20 ` [PATCH 3/6] 9p: don't allow delegations to be set " Jeff Layton
2026-01-07 14:20 ` [PATCH 4/6] gfs2: " Jeff Layton
2026-01-07 14:20 ` [PATCH 5/6] ceph: " Jeff Layton
2026-01-07 20:02   ` [EXTERNAL] " Viacheslav Dubeyko
2026-01-07 14:20 ` [PATCH 6/6] vboxsf: " Jeff Layton
2026-01-07 15:32 ` [PATCH 0/6] vfs: properly deny directory leases on filesystems with special lease handling Christoph Hellwig
2026-01-07 15:44   ` Jeff Layton
2026-01-12  9:55 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260107-setlease-6-19-v1-0-85f034abcc57@kernel.org \
    --to=jlayton@kernel.org \
    --cc=agruenba@redhat.com \
    --cc=anna@kernel.org \
    --cc=asmadeus@codewreck.org \
    --cc=bharathsm@microsoft.com \
    --cc=brauner@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=ericvh@kernel.org \
    --cc=gfs2@lists.linux.dev \
    --cc=hansg@kernel.org \
    --cc=hch@infradead.org \
    --cc=idryomov@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=neil@brown.name \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    --cc=trondmy@kernel.org \
    --cc=v9fs@lists.linux.dev \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiubli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox