From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>, Bharath SM <bharathsm@microsoft.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Xiubo Li <xiubli@redhat.com>, Ilya Dryomov <idryomov@gmail.com>,
Hans de Goede <hansg@kernel.org>, NeilBrown <neil@brown.name>,
Christoph Hellwig <hch@infradead.org>,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
v9fs@lists.linux.dev, gfs2@lists.linux.dev,
ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/6] nfs: properly disallow delegation requests on directories
Date: Thu, 8 Jan 2026 01:24:27 -0800 [thread overview]
Message-ID: <aV93y-xeWk16s48r@infradead.org> (raw)
In-Reply-To: <20260107-setlease-6-19-v1-1-85f034abcc57@kernel.org>
On Wed, Jan 07, 2026 at 09:20:09AM -0500, Jeff Layton wrote:
> Checking for S_ISREG() in nfs4_setlease() is incorrect, since that op is
> never called for directories. The right way to deny lease requests on
> directories is to set the ->setlease() operation to simple_nosetlease()
> in the directory file_operations.
This fixes generic/786 on NFSv4.2 for me, so:
Tested-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-01-08 9:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 14:20 [PATCH 0/6] vfs: properly deny directory leases on filesystems with special lease handling Jeff Layton
2026-01-07 14:20 ` [PATCH 1/6] nfs: properly disallow delegation requests on directories Jeff Layton
2026-01-08 9:24 ` Christoph Hellwig [this message]
2026-01-07 14:20 ` [PATCH 2/6] smb/client: properly disallow delegations " Jeff Layton
2026-01-07 14:20 ` [PATCH 3/6] 9p: don't allow delegations to be set " Jeff Layton
2026-01-07 14:20 ` [PATCH 4/6] gfs2: " Jeff Layton
2026-01-07 14:20 ` [PATCH 5/6] ceph: " Jeff Layton
2026-01-07 20:02 ` [EXTERNAL] " Viacheslav Dubeyko
2026-01-07 14:20 ` [PATCH 6/6] vboxsf: " Jeff Layton
2026-01-07 15:32 ` [PATCH 0/6] vfs: properly deny directory leases on filesystems with special lease handling Christoph Hellwig
2026-01-07 15:44 ` Jeff Layton
2026-01-12 9:55 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aV93y-xeWk16s48r@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=anna@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=bharathsm@microsoft.com \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ericvh@kernel.org \
--cc=gfs2@lists.linux.dev \
--cc=hansg@kernel.org \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=neil@brown.name \
--cc=pc@manguebit.org \
--cc=ronniesahlberg@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=v9fs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox