* [PATCH] fgraph: Make sure fregs is non-null when accessing
@ 2026-01-07 1:51 sunliming
2026-01-07 15:16 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: sunliming @ 2026-01-07 1:51 UTC (permalink / raw)
To: rostedt, mhiramat
Cc: mark.rutland, mathieu.desnoyers, linux-kernel, linux-trace-kernel,
sunliming, kernel test robot, Dan Carpenter
From: sunliming <sunliming@kylinos.cn>
Fix below smatch warnings:
kernel/trace/fgraph.c:834 __ftrace_return_to_handler() error: we previously
assumed 'fregs' could be null (see line 830)
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202512131657.JQUt5fXQ-lkp@intel.com/
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
kernel/trace/fgraph.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
index cc48d16be43e..0f50a55032c5 100644
--- a/kernel/trace/fgraph.c
+++ b/kernel/trace/fgraph.c
@@ -837,7 +837,8 @@ __ftrace_return_to_handler(struct ftrace_regs *fregs, unsigned long frame_pointe
goto out;
#ifdef CONFIG_FUNCTION_GRAPH_RETVAL
- trace.retval = ftrace_regs_get_return_value(fregs);
+ if (fregs)
+ trace.retval = ftrace_regs_get_return_value(fregs);
#endif
bitmap = get_bitmap_bits(current, offset);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fgraph: Make sure fregs is non-null when accessing
2026-01-07 1:51 [PATCH] fgraph: Make sure fregs is non-null when accessing sunliming
@ 2026-01-07 15:16 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2026-01-07 15:16 UTC (permalink / raw)
To: sunliming
Cc: mhiramat, mark.rutland, mathieu.desnoyers, linux-kernel,
linux-trace-kernel, sunliming, kernel test robot, Dan Carpenter
On Wed, 7 Jan 2026 09:51:25 +0800
sunliming@linux.dev wrote:
> From: sunliming <sunliming@kylinos.cn>
>
> Fix below smatch warnings:
> kernel/trace/fgraph.c:834 __ftrace_return_to_handler() error: we previously
> assumed 'fregs' could be null (see line 830)
>
NACK!
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202512131657.JQUt5fXQ-lkp@intel.com/
Really? Did you not read this thread you are "closing"?
-- Steve
> Signed-off-by: sunliming <sunliming@kylinos.cn>
> ---
> kernel/trace/fgraph.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c
> index cc48d16be43e..0f50a55032c5 100644
> --- a/kernel/trace/fgraph.c
> +++ b/kernel/trace/fgraph.c
> @@ -837,7 +837,8 @@ __ftrace_return_to_handler(struct ftrace_regs *fregs, unsigned long frame_pointe
> goto out;
>
> #ifdef CONFIG_FUNCTION_GRAPH_RETVAL
> - trace.retval = ftrace_regs_get_return_value(fregs);
> + if (fregs)
> + trace.retval = ftrace_regs_get_return_value(fregs);
> #endif
>
> bitmap = get_bitmap_bits(current, offset);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-07 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07 1:51 [PATCH] fgraph: Make sure fregs is non-null when accessing sunliming
2026-01-07 15:16 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox