* [PATCH] tracing: Check the return value of tracing_update_buffers()
@ 2026-01-07 21:15 Steven Rostedt
2026-01-08 14:44 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2026-01-07 21:15 UTC (permalink / raw)
To: LKML, Linux Trace Kernel; +Cc: Masami Hiramatsu, Mathieu Desnoyers, Li Zhong
From: Steven Rostedt <rostedt@goodmis.org>
In the very unlikely event that tracing_update_buffers() fails in
trace_printk_init_buffers(), report the failure so that it is known.
Link: https://lore.kernel.org/all/20220917020353.3836285-1-floridsleeves@gmail.com/
Suggested-by: Li Zhong <floridsleeves@gmail.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/trace.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 2d387d56dcd4..1722e01e2238 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -3418,9 +3418,10 @@ void trace_printk_init_buffers(void)
pr_warn("**********************************************************\n");
/* Expand the buffers to set size */
- tracing_update_buffers(&global_trace);
-
- buffers_allocated = 1;
+ if (tracing_update_buffers(&global_trace) < 0)
+ pr_err("Failed to expand tracing buffers for trace_printk() calls\n");
+ else
+ buffers_allocated = 1;
/*
* trace_printk_init_buffers() can be called by modules.
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: Check the return value of tracing_update_buffers()
2026-01-07 21:15 [PATCH] tracing: Check the return value of tracing_update_buffers() Steven Rostedt
@ 2026-01-08 14:44 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2026-01-08 14:44 UTC (permalink / raw)
To: Steven Rostedt
Cc: LKML, Linux Trace Kernel, Masami Hiramatsu, Mathieu Desnoyers,
Li Zhong
On Wed, 7 Jan 2026 16:15:10 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> In the very unlikely event that tracing_update_buffers() fails in
> trace_printk_init_buffers(), report the failure so that it is known.
>
> Link: https://lore.kernel.org/all/20220917020353.3836285-1-floridsleeves@gmail.com/
Good catch! Looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thanks,
>
> Suggested-by: Li Zhong <floridsleeves@gmail.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> kernel/trace/trace.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 2d387d56dcd4..1722e01e2238 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3418,9 +3418,10 @@ void trace_printk_init_buffers(void)
> pr_warn("**********************************************************\n");
>
> /* Expand the buffers to set size */
> - tracing_update_buffers(&global_trace);
> -
> - buffers_allocated = 1;
> + if (tracing_update_buffers(&global_trace) < 0)
> + pr_err("Failed to expand tracing buffers for trace_printk() calls\n");
> + else
> + buffers_allocated = 1;
>
> /*
> * trace_printk_init_buffers() can be called by modules.
> --
> 2.51.0
>
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-08 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07 21:15 [PATCH] tracing: Check the return value of tracing_update_buffers() Steven Rostedt
2026-01-08 14:44 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox