From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ian Rogers <irogers@google.com>, Joe Perches <joe@perches.com>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator
Date: Wed, 14 Jan 2026 16:29:46 +1100 [thread overview]
Message-ID: <20260114162946.4c81298e@canb.auug.org.au> (raw)
In-Reply-To: <20260113193319.701e5799059eb642bbfc9a04@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Hi Andrew,
On Tue, 13 Jan 2026 19:33:19 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> git is wrong. I say so coz I invented the --- convention.
> submitting-patches.rst says
>
> - A marker line containing simply ``---``.
>
> The astonishingly old https://www.ozlabs.org/~akpm/stuff/tpp.txt says
> "... scripts will treat a ^--- string as ...". I regret not
> explicitly using "^---$".
>
> I'd like checkpatch to emit a warning in this case. If a line starts
> with --- then please let's warn the user that downstream tooling will
> screw this up.
https://en.wikipedia.org/wiki/Signature_block#Standard_delimiter
I have used dash-dash-space for as long as I can remember (which varies
these days ;-) ).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-01-14 5:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 5:34 [PATCH v1] checkpatch: Warn about sign offs if there's an accidental patch separator Ian Rogers
2025-12-05 7:22 ` Kuan-Wei Chiu
2026-01-04 1:10 ` Ian Rogers
2026-01-04 17:37 ` Kuan-Wei Chiu
[not found] ` <195a2cba2b461a0ab99ae004bdf079b038db8b07.camel@perches.com>
2026-01-04 21:13 ` Ian Rogers
2026-01-04 22:22 ` Joe Perches
2026-01-05 15:39 ` Ian Rogers
2026-01-05 16:46 ` Joe Perches
2026-01-05 17:13 ` Ian Rogers
2026-01-14 3:33 ` Andrew Morton
2026-01-14 5:29 ` Stephen Rothwell [this message]
2026-01-14 18:20 ` Joe Perches
2026-01-14 19:01 ` Ian Rogers
2026-01-16 17:42 ` [PATCH] checkpatch: Add an invalid patch separator test Joe Perches
2026-01-16 20:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260114162946.4c81298e@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=irogers@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=namhyung@kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox