From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Dominik Karol Piątkowski" <dominik.karol.piatkowski@protonmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
Michael Rubin <matchstick@neverthere.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/12] gpib: agilent_82350b: Unify *allocate_private
Date: Fri, 16 Jan 2026 08:34:29 +0100 [thread overview]
Message-ID: <2026011657-cling-flavoring-2f5b@gregkh> (raw)
In-Reply-To: <20260115191925.52268-2-dominik.karol.piatkowski@protonmail.com>
On Thu, Jan 15, 2026 at 07:20:04PM +0000, Dominik Karol Piątkowski wrote:
> Return values for *allocate_private functions as well as calling code in
> gpib driver are all over the place. Unify them by returning -errno if
> something fails, zero otherwise. Use the returned value as early return
> value in case of error. Replace kmalloc/memset pairs to kzalloc.
This is multiple things in the same patch, which is not a good idea.
Each change should just do one logical thing, this should be broken up
into much smaller pieces.
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-16 7:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 19:20 [PATCH v2 00/12] gpib: Unify *allocate_private Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 01/12] gpib: agilent_82350b: " Dominik Karol Piątkowski
2026-01-16 7:34 ` Greg Kroah-Hartman [this message]
2026-01-16 7:35 ` Greg Kroah-Hartman
2026-01-15 19:20 ` [PATCH v2 02/12] gpib: cb7210: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 03/12] gpib: cec: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 04/12] gpib: eastwood: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 05/12] gpib: fmh_gpib: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 06/12] gpib: gpio: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 07/12] gpib: hp_82335: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 08/12] gpib: hp_82341: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 09/12] gpib: ines: " Dominik Karol Piątkowski
2026-01-15 19:20 ` [PATCH v2 10/12] gpib: ni_usb: " Dominik Karol Piątkowski
2026-01-15 19:21 ` [PATCH v2 11/12] gpib: pc2: " Dominik Karol Piątkowski
2026-01-15 19:21 ` [PATCH v2 12/12] gpib: tnt4882: " Dominik Karol Piątkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011657-cling-flavoring-2f5b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=dominik.karol.piatkowski@protonmail.com \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matchstick@neverthere.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox