Re: [PATCH v3 fwctl 3/5] fwctl/bnxt_en: Create an aux device for fwctl

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Thu, 29 Jan 2026 07:54:51 -0800
Pavan Chebbi <pavan.chebbi@broadcom.com> wrote:

> Create an additional auxiliary device to support fwctl.
> The next patch will create bnxt_fwctl and bind to this
> device.
> 
> Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
> Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 12 ++++++++++--
>  include/linux/bnxt/ulp.h                      |  1 +
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> index 3097fc5755e6..9fd3c1e43224 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
> @@ -50,6 +50,8 @@ static bool bnxt_auxdev_is_active(struct bnxt *bp, int idx)
>  
>  static struct bnxt_aux_device bnxt_aux_devices[__BNXT_AUXDEV_MAX] = {{
>  	.name		= "rdma",
> +}, {
> +	.name		= "fwctl",
>  }};
>  
>  static void bnxt_fill_msix_vecs(struct bnxt *bp, struct bnxt_msix_entry *ent)
> @@ -278,6 +280,11 @@ void bnxt_ulp_stop(struct bnxt *bp)
>  		aux_priv = bp->aux_priv[i];
>  		edev = bp->edev[i];
>  		mutex_lock(&edev->en_dev_lock);
> +		if (i == BNXT_AUXDEV_FWCTL) {

Similar to earlier. I'd like this stuff to be callbacks or data in bnxt_aux_devices
to keep the code flow simpler.

> +			edev->flags |= BNXT_EN_FLAG_ULP_STOPPED;
> +			mutex_unlock(&edev->en_dev_lock);
> +			continue;