[PATCH] regulator: tps65185: check devm_kzalloc() result in probe

[PATCH] regulator: tps65185: check devm_kzalloc() result in probe

[Yufan Chen]

tps65185_probe() dereferences the allocation result immediately by using data->regmap. If devm_kzalloc() returns NULL under memory pressure, this leads to a NULL pointer dereference.

Add the missing allocation check and return -ENOMEM on failure.

Signed-off-by: Yufan Chen <ericterminal@gmail.com>
---
 drivers/regulator/tps65185.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c
index 3286c9ab3..786622d8d 100644
--- a/drivers/regulator/tps65185.c
+++ b/drivers/regulator/tps65185.c
@@ -332,6 +332,9 @@ static int tps65185_probe(struct i2c_client *client)
 	int i;
 
 	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
+
 	data->regmap = devm_regmap_init_i2c(client, &regmap_config);
 	if (IS_ERR(data->regmap))
 		return dev_err_probe(&client->dev, PTR_ERR(data->regmap),
-- 
2.47.3

Re: [PATCH] regulator: tps65185: check devm_kzalloc() result in probe

[Eric_Terminal]

Hi Liam, Mark,

My apologies for using the pseudonym "Eric-Terminal" in the previous
submission of this patch. I am a newcomer and was not aware of the
Linux kernel's policy regarding real names in Signed-off-by tags.

I have just resubmitted the patch with my real name, Yufan Chen
<ericterminal@gmail.com>, and have added the correct Signed-off-by
line. I've also ensured the formatting follows the community
standards.

Thank you for your patience as I learn the contribution process.

Best regards,
Yufan Chen

On Sun, Feb 22, 2026 at 6:40 PM Yufan Chen <ericterminal@gmail.com> wrote:
>
> tps65185_probe() dereferences the allocation result immediately by using data->regmap. If devm_kzalloc() returns NULL under memory pressure, this leads to a NULL pointer dereference.
>
> Add the missing allocation check and return -ENOMEM on failure.
>
> Signed-off-by: Yufan Chen <ericterminal@gmail.com>
> ---
>  drivers/regulator/tps65185.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c
> index 3286c9ab3..786622d8d 100644
> --- a/drivers/regulator/tps65185.c
> +++ b/drivers/regulator/tps65185.c
> @@ -332,6 +332,9 @@ static int tps65185_probe(struct i2c_client *client)
>         int i;
>
>         data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
> +       if (!data)
> +               return -ENOMEM;
> +
>         data->regmap = devm_regmap_init_i2c(client, &regmap_config);
>         if (IS_ERR(data->regmap))
>                 return dev_err_probe(&client->dev, PTR_ERR(data->regmap),
> --
> 2.47.3
>

Re: [PATCH] regulator: tps65185: check devm_kzalloc() result in probe

[Mark Brown]

On Sun, 22 Feb 2026 18:40:35 +0800, Yufan Chen wrote:
> tps65185_probe() dereferences the allocation result immediately by using data->regmap. If devm_kzalloc() returns NULL under memory pressure, this leads to a NULL pointer dereference.
> 
> Add the missing allocation check and return -ENOMEM on failure.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: tps65185: check devm_kzalloc() result in probe
      commit: 4b73231b2a61c4142a027613d277a19c484dfcc3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

[PATCH] regulator: tps65185: check devm_kzalloc() result in probe

[Eric-Terminal]

tps65185_probe() dereferences the allocation result immediately by using data->regmap. If devm_kzalloc() returns NULL under memory pressure, this leads to a NULL pointer dereference.

Add the missing allocation check and return -ENOMEM on failure.

Signed-off-by: Eric-Terminal <ericterminal@gmail.com>
---
 drivers/regulator/tps65185.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c
index 3286c9ab3..786622d8d 100644
--- a/drivers/regulator/tps65185.c
+++ b/drivers/regulator/tps65185.c
@@ -332,6 +332,9 @@ static int tps65185_probe(struct i2c_client *client)
 	int i;
 
 	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
+
 	data->regmap = devm_regmap_init_i2c(client, &regmap_config);
 	if (IS_ERR(data->regmap))
 		return dev_err_probe(&client->dev, PTR_ERR(data->regmap),
-- 
2.47.3