* [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD
@ 2026-02-26 16:43 Felix Gu
2026-02-26 20:04 ` Petre Rodan
2026-02-27 7:14 ` Sebastian Andrzej Siewior
0 siblings, 2 replies; 4+ messages in thread
From: Felix Gu @ 2026-02-26 16:43 UTC (permalink / raw)
To: Petre Rodan, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko
Cc: Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel, Felix Gu
Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
in IRQ request and gives a warning if there is no threaded handler.
Replace IRQF_ONESHOT with IRQF_NO_THREAD.
Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/iio/pressure/abp2030pa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
index 4ca056a73cef..858e13e02bb4 100644
--- a/drivers/iio/pressure/abp2030pa.c
+++ b/drivers/iio/pressure/abp2030pa.c
@@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
if (data->irq > 0) {
- ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
+ ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_NO_THREAD,
dev_name(dev), data);
if (ret)
return ret;
---
base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
change-id: 20260227-abp-016a007ab817
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD
2026-02-26 16:43 [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD Felix Gu
@ 2026-02-26 20:04 ` Petre Rodan
2026-02-27 12:49 ` Felix Gu
2026-02-27 7:14 ` Sebastian Andrzej Siewior
1 sibling, 1 reply; 4+ messages in thread
From: Petre Rodan @ 2026-02-26 20:04 UTC (permalink / raw)
To: Felix Gu
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]
hello,
based on previous feedback [1] IRQF_ONESHOT should be replaced with 0.
[1] https://lore.kernel.org/linux-iio/20260114121448.00000249@huawei.com/
best regards,
peter
On Fri, Feb 27, 2026 at 12:43:51AM +0800, Felix Gu wrote:
> Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
>
> Replace IRQF_ONESHOT with IRQF_NO_THREAD.
>
> Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/iio/pressure/abp2030pa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/abp2030pa.c b/drivers/iio/pressure/abp2030pa.c
> index 4ca056a73cef..858e13e02bb4 100644
> --- a/drivers/iio/pressure/abp2030pa.c
> +++ b/drivers/iio/pressure/abp2030pa.c
> @@ -520,7 +520,7 @@ int abp2_common_probe(struct device *dev, const struct abp2_ops *ops, int irq)
> data->p_offset = div_s64(odelta * data->pmin, pdelta) - data->outmin;
>
> if (data->irq > 0) {
> - ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_ONESHOT,
> + ret = devm_request_irq(dev, irq, abp2_eoc_handler, IRQF_NO_THREAD,
> dev_name(dev), data);
> if (ret)
> return ret;
>
> ---
> base-commit: 7d6661873f6b54c75195780a40d66bad3d482d8f
> change-id: 20260227-abp-016a007ab817
>
> Best regards,
> --
> Felix Gu <ustc.gu@gmail.com>
>
--
petre rodan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 870 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD
2026-02-26 20:04 ` Petre Rodan
@ 2026-02-27 12:49 ` Felix Gu
0 siblings, 0 replies; 4+ messages in thread
From: Felix Gu @ 2026-02-27 12:49 UTC (permalink / raw)
To: Petre Rodan
Cc: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko,
Jonathan Cameron, Sebastian Andrzej Siewior, linux-iio,
linux-kernel
On Fri, Feb 27, 2026 at 4:04 AM Petre Rodan <petre.rodan@subdimension.ro> wrote:
>
>
> hello,
>
> based on previous feedback [1] IRQF_ONESHOT should be replaced with 0.
>
> [1] https://lore.kernel.org/linux-iio/20260114121448.00000249@huawei.com/
>
> best regards,
> peter
Hi Peter,
I checked the handler implementation, IRQF_NO_THREAD is not necessary here.
I will update it in V2.
Best regards,
Felix
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD
2026-02-26 16:43 [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD Felix Gu
2026-02-26 20:04 ` Petre Rodan
@ 2026-02-27 7:14 ` Sebastian Andrzej Siewior
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2026-02-27 7:14 UTC (permalink / raw)
To: Felix Gu
Cc: Petre Rodan, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Jonathan Cameron, linux-iio, linux-kernel
On 2026-02-27 00:43:51 [+0800], Felix Gu wrote:
> Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
> without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
> in IRQ request and gives a warning if there is no threaded handler.
>
> Replace IRQF_ONESHOT with IRQF_NO_THREAD.
>
> Fixes: 47d323ce1e89 ("iio: pressure: add Honeywell ABP2 driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-27 12:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 16:43 [PATCH] iio: pressure: abp2030pa: Replace IRQF_ONESHOT with IRQF_NO_THREAD Felix Gu
2026-02-26 20:04 ` Petre Rodan
2026-02-27 12:49 ` Felix Gu
2026-02-27 7:14 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox