* [PATCH] selftests/sched_ext: Add missing error check for exit__load()
@ 2026-03-13 5:17 David Carlier
2026-03-13 17:03 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: David Carlier @ 2026-03-13 5:17 UTC (permalink / raw)
To: Tejun Heo, David Vernet, Andrea Righi; +Cc: linux-kernel, David Carlier
exit__load(skel) was called without checking its return value.
Every other test in the suite wraps the load call with
SCX_FAIL_IF(). Add the missing check to be consistent with the
rest of the test suite.
Fixes: a5db7817af78 ("sched_ext: Add selftests")
Signed-off-by: David Carlier <devnexen@gmail.com>
---
tools/testing/selftests/sched_ext/exit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/sched_ext/exit.c b/tools/testing/selftests/sched_ext/exit.c
index ee25824b1cbe..b987611789d1 100644
--- a/tools/testing/selftests/sched_ext/exit.c
+++ b/tools/testing/selftests/sched_ext/exit.c
@@ -33,7 +33,7 @@ static enum scx_test_status run(void *ctx)
skel = exit__open();
SCX_ENUM_INIT(skel);
skel->rodata->exit_point = tc;
- exit__load(skel);
+ SCX_FAIL_IF(exit__load(skel), "Failed to load skel");
link = bpf_map__attach_struct_ops(skel->maps.exit_ops);
if (!link) {
SCX_ERR("Failed to attach scheduler");
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/sched_ext: Add missing error check for exit__load()
2026-03-13 5:17 [PATCH] selftests/sched_ext: Add missing error check for exit__load() David Carlier
@ 2026-03-13 17:03 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2026-03-13 17:03 UTC (permalink / raw)
To: David Carlier; +Cc: David Vernet, Andrea Righi, linux-kernel
Applied to sched_ext/for-7.1.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-13 17:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 5:17 [PATCH] selftests/sched_ext: Add missing error check for exit__load() David Carlier
2026-03-13 17:03 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox