* [PATCH] staging: media: atomisp: remove unnecessary parentheses in return statement
@ 2026-03-17 15:56 Teng Liu
2026-04-18 8:25 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Teng Liu @ 2026-03-17 15:56 UTC (permalink / raw)
To: andy, hansg, mchehab, gregkh
Cc: sakari.ailus, linux-kernel, linux-media, linux-staging, Teng Liu
Remove unnecessary parentheses around the return value in
ia_css_pipeline_get_pipe_io_status(). return is not a function,
so parentheses are not required.
This addresses the following checkpatch error:
ERROR: return is not a function, parentheses are not required
Signed-off-by: Teng Liu <27rabbitlt@gmail.com>
---
.../staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c b/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
index 0470871f8..fba567de4 100644
--- a/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
+++ b/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
@@ -446,7 +446,7 @@ bool ia_css_pipeline_has_stopped(struct ia_css_pipeline *pipeline)
struct sh_css_sp_pipeline_io_status *ia_css_pipeline_get_pipe_io_status(void)
{
- return(&sh_css_sp_group.pipe_io_status);
+ return &sh_css_sp_group.pipe_io_status;
}
bool ia_css_pipeline_is_mapped(unsigned int key)
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: media: atomisp: remove unnecessary parentheses in return statement
2026-03-17 15:56 [PATCH] staging: media: atomisp: remove unnecessary parentheses in return statement Teng Liu
@ 2026-04-18 8:25 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2026-04-18 8:25 UTC (permalink / raw)
To: Teng Liu
Cc: andy, hansg, mchehab, gregkh, sakari.ailus, linux-kernel,
linux-media, linux-staging
Hi Teng,
On Tue, Mar 17, 2026 at 04:56:36PM +0100, Teng Liu wrote:
> Remove unnecessary parentheses around the return value in
> ia_css_pipeline_get_pipe_io_status(). return is not a function,
> so parentheses are not required.
>
> This addresses the following checkpatch error:
> ERROR: return is not a function, parentheses are not required
>
> Signed-off-by: Teng Liu <27rabbitlt@gmail.com>
> ---
> .../staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c b/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
> index 0470871f8..fba567de4 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/pipeline/src/pipeline.c
> @@ -446,7 +446,7 @@ bool ia_css_pipeline_has_stopped(struct ia_css_pipeline *pipeline)
>
> struct sh_css_sp_pipeline_io_status *ia_css_pipeline_get_pipe_io_status(void)
> {
> - return(&sh_css_sp_group.pipe_io_status);
> + return &sh_css_sp_group.pipe_io_status;
Is it the only such case in the driver?
> }
>
> bool ia_css_pipeline_is_mapped(unsigned int key)
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-18 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-17 15:56 [PATCH] staging: media: atomisp: remove unnecessary parentheses in return statement Teng Liu
2026-04-18 8:25 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox