* [PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move
@ 2026-03-18 6:14 Ke Zhao
2026-03-18 8:16 ` Cheng-Yang Chou
0 siblings, 1 reply; 2+ messages in thread
From: Ke Zhao @ 2026-03-18 6:14 UTC (permalink / raw)
To: tj, void, arighi, changwoo; +Cc: sched-ext, linux-kernel, bpf, ke.zhao.kernel
The function scx_ops_error() was droped, but the
comment here is left pointing to the old name.
Update to be consistent with current API.
Signed-off-by: Ke Zhao <ke.zhao.kernel@gmail.com>
---
v2:
- Corrected the new function name to scx_bpf_error instead of scx_error.
tools/sched_ext/scx_flatcg.bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/sched_ext/scx_flatcg.bpf.c b/tools/sched_ext/scx_flatcg.bpf.c
index 0e785cff0f24..c0574ff416c7 100644
--- a/tools/sched_ext/scx_flatcg.bpf.c
+++ b/tools/sched_ext/scx_flatcg.bpf.c
@@ -919,7 +919,7 @@ void BPF_STRUCT_OPS(fcg_cgroup_move, struct task_struct *p,
struct fcg_cgrp_ctx *from_cgc, *to_cgc;
s64 delta;
- /* find_cgrp_ctx() triggers scx_ops_error() on lookup failures */
+ /* find_cgrp_ctx() triggers scx_bpf_error() on lookup failures */
if (!(from_cgc = find_cgrp_ctx(from)) || !(to_cgc = find_cgrp_ctx(to)))
return;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move
2026-03-18 6:14 [PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move Ke Zhao
@ 2026-03-18 8:16 ` Cheng-Yang Chou
0 siblings, 0 replies; 2+ messages in thread
From: Cheng-Yang Chou @ 2026-03-18 8:16 UTC (permalink / raw)
To: Ke Zhao
Cc: tj, void, arighi, changwoo, sched-ext, linux-kernel, bpf,
Ching-Chun Huang, Chia-Ping Tsai
Hi Ke,
On Wed, Mar 18, 2026 at 02:14:57PM +0800, Ke Zhao wrote:
> The function scx_ops_error() was droped, but the
Nit:
- s/droped/dropped/
- Use scx_ops_error() and fcg_cgroup_move() (with parentheses) in the
subject to denote functions.
--
Thanks,
Cheng-Yang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-18 8:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 6:14 [PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move Ke Zhao
2026-03-18 8:16 ` Cheng-Yang Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox