public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Chuyi Zhou <zhouchuyi@bytedance.com>
Cc: Nadav Amit <nadav.amit@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	luto@kernel.org, peterz@infradead.org, paulmck@kernel.org,
	muchun.song@linux.dev, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	clrkwllms@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/12] x86/mm: Move flush_tlb_info back to the stack
Date: Thu, 19 Mar 2026 15:40:53 +0100	[thread overview]
Message-ID: <20260319144053.bKDLNrIy@linutronix.de> (raw)
In-Reply-To: <7f4fd9bf-8e8c-44ec-a0e7-64e21abc8d13@bytedance.com>

On 2026-03-19 21:41:28 [+0800], Chuyi Zhou wrote:
> Hi Sebastian,
Hi,

> IIUC, you mean something like the following?

basically yes. Later you might want to add a static_branch to
can_inline_cpumask() instead the check you have now. The value to
cpumask_size() should be assigned once the number of possible CPUs is
known and never change.

> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 5a5d3dbc9cdf..4222114cd34c 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -927,6 +927,8 @@ struct task_struct {
>          unsigned short                  migration_disabled;
>          unsigned short                  migration_flags;
> 
> +       cpumask_t                       *ipi_cpus;

This is probably not the best spot to stuff it. You will have a 4byte
gap there. After user_cpus_ptr would be okay from alignment but I am not
sure if something else shifts too much.

> +
>   #ifdef CONFIG_PREEMPT_RCU
>          int                             rcu_read_lock_nesting;
>          union rcu_special               rcu_read_unlock_special;

Sebastian

  reply	other threads:[~2026-03-19 14:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  4:56 [PATCH v3 00/12] Allow preemption during IPI completion waiting to improve real-time performance Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 01/12] smp: Disable preemption explicitly in __csd_lock_wait Chuyi Zhou
2026-03-18 14:13   ` Steven Rostedt
2026-03-18  4:56 ` [PATCH v3 02/12] smp: Enable preemption early in smp_call_function_single Chuyi Zhou
2026-03-18 14:14   ` Steven Rostedt
2026-03-19  2:30     ` Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 03/12] smp: Remove get_cpu from smp_call_function_any Chuyi Zhou
2026-03-18 14:32   ` Steven Rostedt
2026-03-18 15:39     ` Sebastian Andrzej Siewior
2026-03-18  4:56 ` [PATCH v3 04/12] smp: Use on-stack cpumask in smp_call_function_many_cond Chuyi Zhou
2026-03-18 14:38   ` Steven Rostedt
2026-03-18 15:55   ` Sebastian Andrzej Siewior
2026-03-19  3:02     ` Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 05/12] smp: Free call_function_data via RCU in smpcfd_dead_cpu Chuyi Zhou
2026-03-18 16:19   ` Sebastian Andrzej Siewior
2026-03-19  7:48     ` Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 06/12] smp: Enable preemption early in smp_call_function_many_cond Chuyi Zhou
2026-03-18 16:55   ` Sebastian Andrzej Siewior
2026-03-19  3:46     ` Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 07/12] smp: Remove preempt_disable from smp_call_function Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 08/12] smp: Remove preempt_disable from on_each_cpu_cond_mask Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 09/12] scftorture: Remove preempt_disable in scftorture_invoke_one Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 10/12] x86/mm: Move flush_tlb_info back to the stack Chuyi Zhou
2026-03-18 17:21   ` Sebastian Andrzej Siewior
2026-03-18 20:24     ` Nadav Amit
2026-03-18 22:28       ` Nadav Amit
2026-03-19  8:49         ` Sebastian Andrzej Siewior
2026-03-19 10:37           ` Nadav Amit
2026-03-19 10:58             ` Sebastian Andrzej Siewior
2026-03-19 13:41               ` Chuyi Zhou
2026-03-19 14:40                 ` Sebastian Andrzej Siewior [this message]
2026-03-20 14:33     ` Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 11/12] x86/mm: Enable preemption during native_flush_tlb_multi Chuyi Zhou
2026-03-18  4:56 ` [PATCH v3 12/12] x86/mm: Enable preemption during flush_tlb_kernel_range Chuyi Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319144053.bKDLNrIy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=clrkwllms@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=muchun.song@linux.dev \
    --cc=nadav.amit@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=zhouchuyi@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox