public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, jbaron@akamai.com,
	louis.chauvet@bootlin.com, Jim Cromie <jim.cromie@gmail.com>,
	kernel test robot <oliver.sang@intel.com>
Subject: [PATCH v13 01/36] dyndbg: fix NULL ptr on i386 due to section mis-alignment
Date: Wed,  8 Apr 2026 14:01:36 -0600	[thread overview]
Message-ID: <20260408200211.43821-2-jim.cromie@gmail.com> (raw)
In-Reply-To: <20260408200211.43821-1-jim.cromie@gmail.com>

When dyndbg classmaps get used (later in this series), the
__dyndbg_classes section (which has 28 byte structs on i386), causes
mis-alignment of the following __dyndbg section, resulting in a NULL
pointer deref in dynamic_debug_init().

Fix this by:

Adding ALIGN(8) to the BOUNDED_SECTION* macros.  This aligns all
sections using those macros, including the problem section above.
Almost all the other macro uses are already ALIGN(8), either
directly or by being below one.

Removing BOUNDED_SECTION* uses in ORC_UNWINDER sections.  These
explicitly have smaller alignments, and using the modified macros here
would override that aligment, which scripts/sorttable.c does not
tolerate.

Move __dyndbg section back above __dyndbg_classes, restoring its
orignal position.  This is cosmetic, given the alignment added to the
macros.

Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202601211325.7e1f336-lkp@intel.com
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 include/asm-generic/vmlinux.lds.h | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 1e1580febe4b..58daa551420b 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -212,11 +212,13 @@
 #endif
 
 #define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)	\
+	. = ALIGN(8);							\
 	_BEGIN_##_label_ = .;						\
 	KEEP(*(_sec_))							\
 	_END_##_label_ = .;
 
 #define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)	\
+	. = ALIGN(8);							\
 	_label_##_BEGIN_ = .;						\
 	KEEP(*(_sec_))							\
 	_label_##_END_ = .;
@@ -869,15 +871,21 @@
 #ifdef CONFIG_UNWINDER_ORC
 #define ORC_UNWIND_TABLE						\
 	.orc_header : AT(ADDR(.orc_header) - LOAD_OFFSET) {		\
-		BOUNDED_SECTION_BY(.orc_header, _orc_header)		\
+		__start_orc_header = .;					\
+		KEEP(*(.orc_header))					\
+		__stop_orc_header = .;					\
 	}								\
 	. = ALIGN(4);							\
 	.orc_unwind_ip : AT(ADDR(.orc_unwind_ip) - LOAD_OFFSET) {	\
-		BOUNDED_SECTION_BY(.orc_unwind_ip, _orc_unwind_ip)	\
+		__start_orc_unwind_ip = .;				\
+		KEEP(*(.orc_unwind_ip))					\
+		__stop_orc_unwind_ip = .;				\
 	}								\
 	. = ALIGN(2);							\
 	.orc_unwind : AT(ADDR(.orc_unwind) - LOAD_OFFSET) {		\
-		BOUNDED_SECTION_BY(.orc_unwind, _orc_unwind)		\
+		__start_orc_unwind = .;					\
+		KEEP(*(.orc_unwind))					\
+		__stop_orc_unwind = .;					\
 	}								\
 	text_size = _etext - _stext;					\
 	. = ALIGN(4);							\
-- 
2.53.0


  reply	other threads:[~2026-04-08 20:02 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 20:01 [PATCH v13 00/36] fix dynamic-debug classmaps regression for DRM Jim Cromie
2026-04-08 20:01 ` Jim Cromie [this message]
2026-04-08 20:01 ` [PATCH v13 02/36] vmlinux.lds.h: move BOUNDED_SECTION_* macros to reuse later Jim Cromie
2026-04-08 20:01 ` [PATCH v13 03/36] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie
2026-04-08 20:01 ` [PATCH v13 04/36] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie
2026-04-08 20:01 ` [PATCH v13 05/36] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-04-08 20:01 ` [PATCH v13 06/36] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-04-08 20:01 ` [PATCH v13 07/36] docs/dyndbg: update examples \012 to \n Jim Cromie
2026-04-08 20:01 ` [PATCH v13 08/36] docs/dyndbg: explain flags parse 1st Jim Cromie
2026-04-08 20:01 ` [PATCH v13 09/36] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2026-04-08 20:01 ` [PATCH v13 10/36] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2026-04-08 20:01 ` [PATCH v13 11/36] dyndbg: make ddebug_class_param union members same size Jim Cromie
2026-04-08 20:01 ` [PATCH v13 12/36] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2026-04-08 20:01 ` [PATCH v13 13/36] dyndbg: tweak pr_fmt to avoid expansion conflicts Jim Cromie
2026-04-08 20:01 ` [PATCH v13 14/36] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-04-08 20:01 ` [PATCH v13 15/36] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-04-08 20:01 ` [PATCH v13 16/36] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-04-08 20:01 ` [PATCH v13 17/36] dyndbg: replace classmap list with a vector Jim Cromie
2026-04-08 20:01 ` [PATCH v13 18/36] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-04-08 20:01 ` [PATCH v13 19/36] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-04-08 20:01 ` [PATCH v13 20/36] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-04-08 20:01 ` [PATCH v13 21/36] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2026-04-08 20:01 ` [PATCH v13 22/36] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-04-08 20:01 ` [PATCH v13 23/36] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-04-08 20:01 ` [PATCH v13 24/36] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2026-04-08 20:02 ` [PATCH v13 25/36] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-04-08 20:02 ` [PATCH v13 26/36] dyndbg: detect class_id reservation conflicts Jim Cromie
2026-04-08 20:02 ` [PATCH v13 27/36] dyndbg: check DYNAMIC_DEBUG_CLASSMAP_{DEFINE,USE_} args at compile-time Jim Cromie
2026-04-08 20:02 ` [PATCH v13 28/36] dyndbg-test: change do_prints testpoint to accept a loopct Jim Cromie
2026-04-08 20:02 ` [PATCH v13 29/36] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API Jim Cromie
2026-04-08 20:02 ` [PATCH v13 30/36] dyndbg: treat comma as a token separator Jim Cromie
2026-04-08 20:02 ` [PATCH v13 31/36] dyndbg: split multi-query strings with % Jim Cromie
2026-04-08 20:02 ` [PATCH v13 32/36] selftests-dyndbg: add test_mod_submod Jim Cromie
2026-04-08 20:02 ` [PATCH v13 33/36] dyndbg: resolve "protection" of class'd pr_debug Jim Cromie
2026-04-08 20:02 ` [PATCH v13 34/36] dyndbg: harden classmap and descriptor validation Jim Cromie
2026-04-08 20:02 ` [PATCH v13 35/36] docs/dyndbg: add classmap info to howto Jim Cromie
2026-04-08 20:02 ` [PATCH v13 36/36] dyndbg: Ignore additional arguments from pr_fmt Jim Cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408200211.43821-2-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbaron@akamai.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox