public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Finkelbaum <regpacy@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Michael Straube <straube.linux@gmail.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Ethan Tidmore <ethantidmore06@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Marc Finkelbaum <regpacy@gmail.com>
Subject: [PATCH 6/9] staging: rtl8723bs: fix Yoda conditions and == false comparisons
Date: Tue, 14 Apr 2026 12:58:30 +0300	[thread overview]
Message-ID: <20260414095833.76480-7-regpacy@gmail.com> (raw)
In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com>

Replace reversed comparisons with natural-order equivalents:
  - '0xFF == hw_channel_plan' -> 'hw_channel_plan == 0xFF'
  - 'false == pHalData->bDisableSWChannelPlan' -> '!pHalData->...'
  - 'is_supported_24g(...) == false' -> '!is_supported_24g(...)'

The multi-line if condition around bDisableSWChannelPlan is also
reformatted to standard kernel one-line style.

No functional change.

Signed-off-by: Marc Finkelbaum <regpacy@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index fcfcdfd079da..dc5e6a58fd9d 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -105,7 +105,7 @@ u8 hal_com_config_channel_plan(
 	pHalData->bDisableSWChannelPlan = false;
 	chnlPlan = def_channel_plan;
 
-	if (0xFF == hw_channel_plan)
+	if (hw_channel_plan == 0xFF)
 		AutoLoadFail = true;
 
 	if (!AutoLoadFail) {
@@ -120,10 +120,8 @@ u8 hal_com_config_channel_plan(
 		}
 	}
 
-	if (
-		(false == pHalData->bDisableSWChannelPlan) &&
-		rtw_is_channel_plan_valid(sw_channel_plan)
-	)
+	if ((!pHalData->bDisableSWChannelPlan) &&
+	    rtw_is_channel_plan_valid(sw_channel_plan))
 		chnlPlan = sw_channel_plan;
 
 	return chnlPlan;
@@ -134,7 +132,7 @@ bool HAL_IsLegalChannel(struct adapter *adapter, u32 Channel)
 	bool bLegalChannel = true;
 
 	if ((Channel <= 14) && (Channel >= 1)) {
-		if (is_supported_24g(adapter->registrypriv.wireless_mode) == false)
+		if (!is_supported_24g(adapter->registrypriv.wireless_mode))
 			bLegalChannel = false;
 	} else {
 		bLegalChannel = false;
-- 
2.53.0


  parent reply	other threads:[~2026-04-14  9:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-14  9:58 [PATCH 0/9] staging: rtl8723bs: coding style cleanup in hal_com.c Marc Finkelbaum
2026-04-14  9:58 ` [PATCH 1/9] staging: rtl8723bs: remove extra blank lines Marc Finkelbaum
2026-04-14 11:45   ` Andy Shevchenko
2026-04-14  9:58 ` [PATCH 2/9] staging: rtl8723bs: fix space-before-tab whitespace Marc Finkelbaum
2026-04-14 11:48   ` Andy Shevchenko
2026-04-14  9:58 ` [PATCH 3/9] staging: rtl8723bs: fix block comment alignment Marc Finkelbaum
2026-04-14 11:51   ` Andy Shevchenko
2026-04-14  9:58 ` [PATCH 4/9] staging: rtl8723bs: add spaces around binary operators Marc Finkelbaum
2026-04-14 11:58   ` Andy Shevchenko
2026-04-14  9:58 ` [PATCH 5/9] staging: rtl8723bs: add space before inline block comments Marc Finkelbaum
2026-04-14 12:12   ` Andy Shevchenko
2026-04-14  9:58 ` Marc Finkelbaum [this message]
2026-04-14 12:21   ` [PATCH 6/9] staging: rtl8723bs: fix Yoda conditions and == false comparisons Andy Shevchenko
2026-04-14 18:25     ` Luka Gejak
2026-04-14  9:58 ` [PATCH 7/9] staging: rtl8723bs: reformat multi-line function signatures Marc Finkelbaum
2026-04-14  9:58 ` [PATCH 8/9] staging: rtl8723bs: reformat switch-case blocks with braced bodies Marc Finkelbaum
2026-04-14  9:58 ` [PATCH 9/9] staging: rtl8723bs: wrap long lines and fix argument alignment Marc Finkelbaum
2026-04-14 12:31   ` Andy Shevchenko
2026-04-14 16:08 ` [PATCH 0/9] staging: rtl8723bs: coding style cleanup in hal_com.c regpac youtube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260414095833.76480-7-regpacy@gmail.com \
    --to=regpacy@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox