public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value
@ 2026-04-14  2:59 Douglas Anderson
  2026-04-14  3:40 ` Randy Dunlap
  2026-04-14 10:12 ` Danilo Krummrich
  0 siblings, 2 replies; 3+ messages in thread
From: Douglas Anderson @ 2026-04-14  2:59 UTC (permalink / raw)
  To: Danilo Krummrich, Greg Kroah-Hartman
  Cc: Randy Dunlap, Mark Brown, driver-core, Douglas Anderson,
	Marek Szyprowski, Rafael J. Wysocki, linux-kernel

Even though nobody should use this value (except when declaring the
"flags" bitmap), kernel-doc still gets upset that it's not documented.
It reports:

  WARNING: ../include/linux/device.h:519
  Enum value 'DEV_FLAG_COUNT' not described in enum 'struct_device_flags'

Add the description of DEV_FLAG_COUNT.

Fixes: a2225b6e834a ("driver core: Don't let a device probe until it's ready")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/f318cd43-81fd-48b9-abf7-92af85f12f91@infradead.org
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 include/linux/device.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/device.h b/include/linux/device.h
index 1c27505476bb..9c8fde6a3d86 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -512,6 +512,7 @@ struct device_physical_location {
  *
  * @DEV_FLAG_READY_TO_PROBE: If set then device_add() has finished enough
  *		initialization that probe could be called.
+ * @DEV_FLAG_COUNT: Number of defined struct_device_flags.
  */
 enum struct_device_flags {
 	DEV_FLAG_READY_TO_PROBE = 0,
-- 
2.54.0.rc0.605.g598a273b03-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value
  2026-04-14  2:59 [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value Douglas Anderson
@ 2026-04-14  3:40 ` Randy Dunlap
  2026-04-14 10:12 ` Danilo Krummrich
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-04-14  3:40 UTC (permalink / raw)
  To: Douglas Anderson, Danilo Krummrich, Greg Kroah-Hartman
  Cc: Mark Brown, driver-core, Marek Szyprowski, Rafael J. Wysocki,
	linux-kernel



On 4/13/26 7:59 PM, Douglas Anderson wrote:
> Even though nobody should use this value (except when declaring the
> "flags" bitmap), kernel-doc still gets upset that it's not documented.
> It reports:
> 
>   WARNING: ../include/linux/device.h:519
>   Enum value 'DEV_FLAG_COUNT' not described in enum 'struct_device_flags'
> 
> Add the description of DEV_FLAG_COUNT.
> 
> Fixes: a2225b6e834a ("driver core: Don't let a device probe until it's ready")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/f318cd43-81fd-48b9-abf7-92af85f12f91@infradead.org
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Tested-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> 
>  include/linux/device.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 1c27505476bb..9c8fde6a3d86 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -512,6 +512,7 @@ struct device_physical_location {
>   *
>   * @DEV_FLAG_READY_TO_PROBE: If set then device_add() has finished enough
>   *		initialization that probe could be called.
> + * @DEV_FLAG_COUNT: Number of defined struct_device_flags.
>   */
>  enum struct_device_flags {
>  	DEV_FLAG_READY_TO_PROBE = 0,

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value
  2026-04-14  2:59 [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value Douglas Anderson
  2026-04-14  3:40 ` Randy Dunlap
@ 2026-04-14 10:12 ` Danilo Krummrich
  1 sibling, 0 replies; 3+ messages in thread
From: Danilo Krummrich @ 2026-04-14 10:12 UTC (permalink / raw)
  To: Douglas Anderson
  Cc: Danilo Krummrich, Greg Kroah-Hartman, Randy Dunlap, Mark Brown,
	driver-core, Marek Szyprowski, Rafael J . Wysocki, linux-kernel

On Mon, 13 Apr 2026 19:59:11 -0700, Douglas Anderson wrote:
> [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value

Applied, thanks!

  Branch: driver-core-linus
  Tree:   git://git.kernel.org/pub/scm/linux/kernel/git/driver-core/driver-core.git

[1/1] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value
      commit: 5b484311507b

The patch will appear in the next linux-next integration (typically within 24
hours on weekdays.)

The patch is queued up for Linus's tree and should land in the next -rc release.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-14 10:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-14  2:59 [PATCH] driver core: Add kernel-doc for DEV_FLAG_COUNT enum value Douglas Anderson
2026-04-14  3:40 ` Randy Dunlap
2026-04-14 10:12 ` Danilo Krummrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox