From: Chris Leech <cleech@redhat.com>
To: alistair23@gmail.com
Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2] nvme-auth: Include SC_C in RVAL controller hash
Date: Wed, 15 Apr 2026 18:18:00 -0700 [thread overview]
Message-ID: <20260415-coroner-hamlet-36ab7e08cd30@redhat.com> (raw)
In-Reply-To: <20260415230824.2790058-1-alistair.francis@wdc.com>
On Thu, Apr 16, 2026 at 09:08:24AM +1000, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is
> included in the Response Value (RVAL) hash and SC_C should be included.
> Currently we are hardcoding 0 instead of using the correct SC_C value.
>
> Update the host and target code to use the SC_C when calculating the
> RVAL instead of using 0.
>
> Fixes: f50fff73d620 ("nvme: implement In-Band authentication")
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> v2:
> - Rebase using new nvme_auth_hmac_update() functions
>
> drivers/nvme/host/auth.c | 3 ++-
> drivers/nvme/target/auth.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Thanks, this was a good catch. Fix looks good to me.
Reviewed-by: Chris Leech <cleech@redhat.com>
next prev parent reply other threads:[~2026-04-16 1:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 23:08 [PATCH v2] nvme-auth: Include SC_C in RVAL controller hash alistair23
2026-04-16 1:18 ` Chris Leech [this message]
2026-04-16 5:16 ` Christoph Hellwig
2026-04-16 5:25 ` Alistair Francis
2026-04-16 6:23 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415-coroner-hamlet-36ab7e08cd30@redhat.com \
--to=cleech@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox