From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
sanjayembeddedse@gmail.com, tglx@kernel.org,
christophe.jaillet@wanadoo.fr, mingo@kernel.org,
nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 4/7] iio: ssp_sensors: drop duplicated wdt timer and work cleanup
Date: Wed, 15 Apr 2026 10:37:46 +0530 [thread overview]
Message-ID: <20260415050749.3858046-5-sanjayembedded@gmail.com> (raw)
In-Reply-To: <20260415050749.3858046-1-sanjayembedded@gmail.com>
From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
The SSP remove path cleans up the watchdog timer and associated work
both via ssp_disable_wdt_timer() and through explicit timer and work
teardown.
Remove the duplicated timer_delete_sync() and cancel_work_sync()
calls and rely on ssp_disable_wdt_timer() as the single cleanup helper
to simplify the remove path.
No functional change intended.
Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
---
drivers/iio/common/ssp_sensors/ssp_dev.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
index da09c9f3ceb6..cb4c26a6b76c 100644
--- a/drivers/iio/common/ssp_sensors/ssp_dev.c
+++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
@@ -585,14 +585,11 @@ static void ssp_remove(struct spi_device *spi)
"SSP_MSG2SSP_AP_STATUS_SHUTDOWN failed\n");
ssp_enable_mcu(data, false);
- ssp_disable_wdt_timer(data);
-
ssp_clean_pending_list(data);
free_irq(data->spi->irq, data);
- timer_delete_sync(&data->wdt_timer);
- cancel_work_sync(&data->work_wdt);
+ ssp_disable_wdt_timer(data);
mutex_destroy(&data->comm_lock);
mutex_destroy(&data->pending_lock);
--
2.34.1
next prev parent reply other threads:[~2026-04-15 5:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 5:07 [PATCH v6 0/7] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 1/7] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 2/7] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-04-15 9:14 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 3/7] iio: ssp_sensors: factor out pending list add/remove helper(s) Sanjay Chitroda
2026-04-15 9:22 ` Andy Shevchenko
2026-04-15 9:25 ` Andy Shevchenko
2026-04-15 5:07 ` Sanjay Chitroda [this message]
2026-04-15 9:29 ` [PATCH v6 4/7] iio: ssp_sensors: drop duplicated wdt timer and work cleanup Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 5/7] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-04-15 9:33 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 6/7] iio: ssp_sensors: Use dev_err_probe Sanjay Chitroda
2026-04-15 9:39 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 7/7] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415050749.3858046-5-sanjayembedded@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox