From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, tglx@kernel.org, christophe.jaillet@wanadoo.fr,
mingo@kernel.org, nabijaczleweli@nabijaczleweli.xyz,
kees@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/7] iio: ssp_sensors: factor out pending list add/remove helper(s)
Date: Wed, 15 Apr 2026 12:22:51 +0300 [thread overview]
Message-ID: <ad9Y6-WHWs09hkbe@ashevche-desk.local> (raw)
In-Reply-To: <20260415050749.3858046-4-sanjayembedded@gmail.com>
On Wed, Apr 15, 2026 at 10:37:45AM +0530, Sanjay Chitroda wrote:
> The SSP SPI transfer path manipulates the pending message list in
> multiple places, each time open-coding the same locking and list
> operations.
>
> Re-factor the pending list add and delete logic into small helper
> functions and drop use_no_irq variable to avoid duplication and
> simplify transfer flow to follow.
>
> No functional change intended.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
after addressing below nit-picks.
...
> +static inline void ssp_pending_add(struct ssp_data *data,
> + struct ssp_msg *msg)
It's perfectly a single line (we have limit 80, so up to and including 80 is
allowed).
static inline void ssp_pending_add(struct ssp_data *data, struct ssp_msg *msg)
(it's only 78 here).
...
> +static inline void ssp_pending_del(struct ssp_data *data,
> + struct ssp_msg *msg)
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-15 9:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 5:07 [PATCH v6 0/7] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 1/7] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 2/7] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-04-15 9:14 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 3/7] iio: ssp_sensors: factor out pending list add/remove helper(s) Sanjay Chitroda
2026-04-15 9:22 ` Andy Shevchenko [this message]
2026-04-15 9:25 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 4/7] iio: ssp_sensors: drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-04-15 9:29 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 5/7] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-04-15 9:33 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 6/7] iio: ssp_sensors: Use dev_err_probe Sanjay Chitroda
2026-04-15 9:39 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 7/7] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad9Y6-WHWs09hkbe@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
--cc=sanjayembeddedse@gmail.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox