public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] Fix EIC7700 USB reset's issue
@ 2026-04-15  6:40 caohang
  2026-04-15  6:42 ` [PATCH v2 1/1] dt-bindings: usb: " caohang
  0 siblings, 1 reply; 3+ messages in thread
From: caohang @ 2026-04-15  6:40 UTC (permalink / raw)
  To: gregkh, robh, krzk+dt, conor+dt, Thinh.Nguyen, p.zabel,
	linux-kernel, linux-usb, devicetree
  Cc: ningyu, linmin, pinkesh.vaghela, Hang Cao

From: Hang Cao <caohang@eswincomputing.com>

Fix EIC7700 USB reset's issue

Changes in v2->v1:
- Update commit message.
- Link to V1:https://lore.kernel.org/all/20260407061703.1564-1-caohang@eswincomputing.com/

Hang Cao (1):
  dt-bindings: usb: Fix EIC7700 USB reset's issue

 .../devicetree/bindings/usb/eswin,eic7700-usb.yaml         | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

--
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/1] dt-bindings: usb: Fix EIC7700 USB reset's issue
  2026-04-15  6:40 [PATCH v2 0/1] Fix EIC7700 USB reset's issue caohang
@ 2026-04-15  6:42 ` caohang
  2026-04-15 14:47   ` Conor Dooley
  0 siblings, 1 reply; 3+ messages in thread
From: caohang @ 2026-04-15  6:42 UTC (permalink / raw)
  To: gregkh, robh, krzk+dt, conor+dt, Thinh.Nguyen, p.zabel,
	linux-kernel, linux-usb, devicetree
  Cc: ningyu, linmin, pinkesh.vaghela, Hang Cao

From: Hang Cao <caohang@eswincomputing.com>

The EIC7700 USB requires a USB PHY reset operation; otherwise, the USB
will not work. The reason why the USB driver that was applied can work
properly is that the USB PHY has already been reset in ESWIN's U-Boot.

However, the proper functioning of the USB driver should not be dependent
on the bootloader. Therefore, it is necessary to incorporate the USB PHY
reset signal into the DT bindings.

This patch does not introduce any backward incompatibility since the dts
is not upstream yet. As array of reset operations are used in the driver,
no modifications to the USB controller driver are needed.

Fixes: c640a4239db5 ("dt-bindings: usb: Add ESWIN EIC7700 USB controller")
Signed-off-by: Hang Cao <caohang@eswincomputing.com>
---
 .../devicetree/bindings/usb/eswin,eic7700-usb.yaml         | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/eswin,eic7700-usb.yaml b/Documentation/devicetree/bindings/usb/eswin,eic7700-usb.yaml
index 41c3b1b98991..658260619423 100644
--- a/Documentation/devicetree/bindings/usb/eswin,eic7700-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/eswin,eic7700-usb.yaml
@@ -41,12 +41,13 @@ properties:
       - const: usb_en

   resets:
-    maxItems: 2
+    maxItems: 3

   reset-names:
     items:
       - const: vaux
       - const: usb_rst
+      - const: usb_phy

   eswin,hsp-sp-csr:
     description:
@@ -85,8 +86,8 @@ examples:
         interrupt-parent = <&plic>;
         interrupts = <85>;
         interrupt-names = "peripheral";
-        resets = <&reset 84>, <&hspcrg 2>;
-        reset-names = "vaux", "usb_rst";
+        resets = <&reset 84>, <&hspcrg 2>, <&hspcrg 4>;
+        reset-names = "vaux", "usb_rst", "usb_phy";
         dr_mode = "peripheral";
         maximum-speed = "high-speed";
         phy_type = "utmi";
--
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] dt-bindings: usb: Fix EIC7700 USB reset's issue
  2026-04-15  6:42 ` [PATCH v2 1/1] dt-bindings: usb: " caohang
@ 2026-04-15 14:47   ` Conor Dooley
  0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2026-04-15 14:47 UTC (permalink / raw)
  To: caohang
  Cc: gregkh, robh, krzk+dt, conor+dt, Thinh.Nguyen, p.zabel,
	linux-kernel, linux-usb, devicetree, ningyu, linmin,
	pinkesh.vaghela

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

On Wed, Apr 15, 2026 at 02:42:38PM +0800, caohang@eswincomputing.com wrote:
> From: Hang Cao <caohang@eswincomputing.com>
> 
> The EIC7700 USB requires a USB PHY reset operation; otherwise, the USB
> will not work. The reason why the USB driver that was applied can work
> properly is that the USB PHY has already been reset in ESWIN's U-Boot.
> 
> However, the proper functioning of the USB driver should not be dependent
> on the bootloader. Therefore, it is necessary to incorporate the USB PHY
> reset signal into the DT bindings.
> 
> This patch does not introduce any backward incompatibility since the dts
> is not upstream yet. As array of reset operations are used in the driver,
> no modifications to the USB controller driver are needed.
> 
> Fixes: c640a4239db5 ("dt-bindings: usb: Add ESWIN EIC7700 USB controller")
> Signed-off-by: Hang Cao <caohang@eswincomputing.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-15 14:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-15  6:40 [PATCH v2 0/1] Fix EIC7700 USB reset's issue caohang
2026-04-15  6:42 ` [PATCH v2 1/1] dt-bindings: usb: " caohang
2026-04-15 14:47   ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox