public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Baran Arda <baran9arda@gmail.com>
To: asmadeus@codewreck.org
Cc: ericvh@kernel.org, lucho@ionkov.net, linux_oss@crudebyte.com,
	v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
	Baran Arda <baran9arda@gmail.com>
Subject: [PATCH v2] fs/9p: remove unnecessary extern keywords from function prototypes
Date: Thu, 16 Apr 2026 12:04:38 +0300	[thread overview]
Message-ID: <20260416090438.42844-1-baran9arda@gmail.com> (raw)
In-Reply-To: <aeBOjl59tgjvGkU1@codewreck.org>

Hello Dominique,

Thank you for your feedback. In this second version, I have removed the 'extern' keywords only from function prototypes.

I understand this is a minor cleanup, but it is my first contribution to the Linux kernel and I am excited to learn the process. I appreciate your time and effort in reviewing this.

Best regards,
Baran Arda

fs/9p: remove unnecessary extern keywords from function prototypes

Remove explicit extern keywords from function prototypes in 9p
header files. This cleans up the code in accordance with the
kernel coding style.

Signed-off-by: Baran Arda <baran9arda@gmail.com>
---
v2:
- Restored 'extern' keywords for variables as requested by maintainers.
- Only modified function prototypes in this version.

 fs/9p/cache.h |  6 +++---
 fs/9p/v9fs.h  | 24 ++++++++++++------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/fs/9p/cache.h b/fs/9p/cache.h
index ee1b6b06a2fd..25f0dd58122e 100644
--- a/fs/9p/cache.h
+++ b/fs/9p/cache.h
@@ -11,10 +11,10 @@
 #ifdef CONFIG_9P_FSCACHE
 #include <linux/fscache.h>
 
-extern int v9fs_cache_session_get_cookie(struct v9fs_session_info *v9ses,
-					  const char *dev_name);
+int v9fs_cache_session_get_cookie(struct v9fs_session_info *v9ses,
+					const char *dev_name);
 
-extern void v9fs_cache_inode_get_cookie(struct inode *inode);
+void v9fs_cache_inode_get_cookie(struct inode *inode);
 
 #else /* CONFIG_9P_FSCACHE */
 
diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
index 6a12445d3858..2d37505704a9 100644
--- a/fs/9p/v9fs.h
+++ b/fs/9p/v9fs.h
@@ -168,30 +168,30 @@ static inline struct fscache_volume *v9fs_session_cache(struct v9fs_session_info
 
 extern const struct fs_parameter_spec v9fs_param_spec[];
 
-extern int v9fs_parse_param(struct fs_context *fc, struct fs_parameter *param);
-extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
+int v9fs_parse_param(struct fs_context *fc, struct fs_parameter *param);
+int v9fs_show_options(struct seq_file *m, struct dentry *root);
 
 struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses,
 				 struct fs_context *fc);
-extern void v9fs_session_close(struct v9fs_session_info *v9ses);
-extern void v9fs_session_cancel(struct v9fs_session_info *v9ses);
-extern void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses);
-extern struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
-				      unsigned int flags);
-extern int v9fs_vfs_unlink(struct inode *i, struct dentry *d);
-extern int v9fs_vfs_rmdir(struct inode *i, struct dentry *d);
-extern int v9fs_vfs_rename(struct mnt_idmap *idmap,
+void v9fs_session_close(struct v9fs_session_info *v9ses);
+void v9fs_session_cancel(struct v9fs_session_info *v9ses);
+void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses);
+struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry,
+			      unsigned int flags);
+int v9fs_vfs_unlink(struct inode *i, struct dentry *d);
+int v9fs_vfs_rmdir(struct inode *i, struct dentry *d);
+int v9fs_vfs_rename(struct mnt_idmap *idmap,
 			   struct inode *old_dir, struct dentry *old_dentry,
 			   struct inode *new_dir, struct dentry *new_dentry,
 			   unsigned int flags);
-extern struct inode *v9fs_inode_from_fid(struct v9fs_session_info *v9ses,
+struct inode *v9fs_inode_from_fid(struct v9fs_session_info *v9ses,
 					 struct p9_fid *fid,
 					 struct super_block *sb, int new);
 extern const struct inode_operations v9fs_dir_inode_operations_dotl;
 extern const struct inode_operations v9fs_file_inode_operations_dotl;
 extern const struct inode_operations v9fs_symlink_inode_operations_dotl;
 extern const struct netfs_request_ops v9fs_req_ops;
-extern struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses,
+struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses,
 					      struct p9_fid *fid,
 					      struct super_block *sb, int new);
 



      reply	other threads:[~2026-04-16  9:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 20:26 [PATCH] fs/9p: remove unnecessary extern keywords from header files Baran Arda
2026-04-16  1:55 ` Dominique Martinet
2026-04-16  2:50 ` Dominique Martinet
2026-04-16  9:04   ` Baran Arda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416090438.42844-1-baran9arda@gmail.com \
    --to=baran9arda@gmail.com \
    --cc=asmadeus@codewreck.org \
    --cc=ericvh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=v9fs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox