Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
> 
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f0..cf5698dda91fc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1534,7 +1534,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  			precvpriv->rx_drop++;
>  		} else if (retval == _SUCCESS) {
>  #ifdef DBG_RX_DUMP_EAP
> -			u8 bDumpRxPkt;

If you trace this back, why is this variable being used at all?  Look at
how it is being used, and please explain the logic here.

Personally, I think this can be deleted entirely, but please verify
this.

thanks,

greg k-h