From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yuho Choi <dbgh9129@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, Hans de Goede <hansg@kernel.org>,
Michael Straube <straube.linux@gmail.com>,
Minu Jin <s9430939@naver.com>, Ingo Molnar <mingo@kernel.org>,
Ethan Tidmore <ethantidmore06@gmail.com>,
William Hansen-Baird <william.hansen.baird@gmail.com>,
linux-kernel@vger.kernel.org, Myeonghun Pak <mhun512@gmail.com>,
Ijae Kim <ae878000@gmail.com>, Taegyu Kim <tmk5904@psu.edu>
Subject: Re: [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration
Date: Mon, 20 Apr 2026 11:25:44 +0300 [thread overview]
Message-ID: <aeXjCFcx_usLQkK0@ashevche-desk.local> (raw)
In-Reply-To: <20260420030543.72423-1-dbgh9129@gmail.com>
On Sun, Apr 19, 2026 at 11:05:43PM -0400, Yuho Choi wrote:
> DBG_RX_DUMP_EAP redeclares bDumpRxPkt inside validate_recv_frame(),
> shadowing the existing function-local variable. Drop the inner declaration
> and reuse the existing variable to avoid unnecessary shadowing.
> Co-developed-by: Myeonghun Pak <mhun512@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Co-developed-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Taegyu Kim <tmk5904@psu.edu>
> Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
You are kidding me...
> drivers/staging/rtl8723bs/core/rtw_recv.c | 1 -
> 1 file changed, 1 deletion(-)
^^^^^^^^
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-20 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 3:05 [PATCH v1] staging: rtl8723bs: remove shadowed bDumpRxPkt declaration Yuho Choi
2026-04-20 8:25 ` Andy Shevchenko [this message]
2026-04-20 10:03 ` Greg Kroah-Hartman
2026-04-20 22:08 ` Ethan Tidmore
2026-04-20 23:00 ` 최유호
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeXjCFcx_usLQkK0@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=ae878000@gmail.com \
--cc=dbgh9129@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mhun512@gmail.com \
--cc=mingo@kernel.org \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=tmk5904@psu.edu \
--cc=william.hansen.baird@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox