public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pengpeng Hou <pengpeng@iscas.ac.cn>
To: Petr Pavlu <petr.pavlu@suse.com>
Cc: Daniel Gomez <da.gomez@samsung.com>,
	Sami Tolvanen <samitolvanen@google.com>,
	Aaron Tomlin <atomlin@atomlin.com>, Kees Cook <kees@kernel.org>,
	Dmitry Antipov <dmantipov@yandex.ru>,
	Thorsten Blum <thorsten.blum@linux.dev>,
	linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn
Subject: Re: [PATCH] params: bound array element output to the caller's page buffer
Date: Fri, 24 Apr 2026 06:49:31 +0800	[thread overview]
Message-ID: <20260424070107.1-params-reply-pengpeng@iscas.ac.cn> (raw)
In-Reply-To: <20260417075042.26632-1-pengpeng@iscas.ac.cn>

Hi Petr,

Thanks, that makes sense.

I agree that adding an explicit size argument to kernel_param_ops::get()
would be the cleaner interface. My patch was trying to keep the fix
local to param_array_get(), since changing the callback signature would
touch all current implementations.

My inclination would be to keep the immediate fix local to
param_array_get() first, since that seems more suitable for a bug fix and
doesn't require touching every current ->get() implementation.

If you'd rather take the interface cleanup first, I'm happy to work on a
larger series that extends ->get() with a size argument and then uses it
in param_array_get().

Thanks,
Pengpeng



  parent reply	other threads:[~2026-04-23 22:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  7:50 [PATCH] params: bound array element output to the caller's page buffer Pengpeng Hou
2026-04-23  9:34 ` Petr Pavlu
2026-04-23 22:49 ` Pengpeng Hou [this message]
2026-05-05  9:08 ` Petr Pavlu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260424070107.1-params-reply-pengpeng@iscas.ac.cn \
    --to=pengpeng@iscas.ac.cn \
    --cc=atomlin@atomlin.com \
    --cc=da.gomez@samsung.com \
    --cc=dmantipov@yandex.ru \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=thorsten.blum@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox