From: Uros Bizjak <ubizjak@gmail.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Uros Bizjak <ubizjak@gmail.com>, Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@kernel.org>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH RESEND -tip v2 3/7] x86/ptrace: Use savesegment() in get_segment_reg() instead of inline asm
Date: Tue, 28 Apr 2026 18:03:37 +0200 [thread overview]
Message-ID: <20260428160443.3593331-3-ubizjak@gmail.com> (raw)
In-Reply-To: <20260428160443.3593331-1-ubizjak@gmail.com>
Replace direct 'movl' instructions for DS, ES, FS, and GS read in
get_segment_reg() with the savesegment() helper. This improves
readability, consistency, and ensures proper handling of
segment registers on x86_64.
No functional change intended.
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
arch/x86/kernel/ptrace.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index 3dcadc13f09a..4cb00aa0645f 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -251,32 +251,31 @@ static u16 get_segment_reg(struct task_struct *task, unsigned long offset)
/*
* Returning the value truncates it to 16 bits.
*/
- unsigned int seg;
+ unsigned int retval;
switch (offset) {
case offsetof(struct user_regs_struct, fs):
if (task == current) {
- /* Older gas can't assemble movq %?s,%r?? */
- asm("movl %%fs,%0" : "=r" (seg));
- return seg;
+ savesegment(fs, retval);
+ return retval;
}
return task->thread.fsindex;
case offsetof(struct user_regs_struct, gs):
if (task == current) {
- asm("movl %%gs,%0" : "=r" (seg));
- return seg;
+ savesegment(gs, retval);
+ return retval;
}
return task->thread.gsindex;
case offsetof(struct user_regs_struct, ds):
if (task == current) {
- asm("movl %%ds,%0" : "=r" (seg));
- return seg;
+ savesegment(ds, retval);
+ return retval;
}
return task->thread.ds;
case offsetof(struct user_regs_struct, es):
if (task == current) {
- asm("movl %%es,%0" : "=r" (seg));
- return seg;
+ savesegment(es, retval);
+ return retval;
}
return task->thread.es;
--
2.53.0
next prev parent reply other threads:[~2026-04-28 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 16:03 [PATCH RESEND -tip v2 1/7] x86_32/segment: Always return correctly zero-extended values from savesegment_*() Uros Bizjak
2026-04-28 16:03 ` [PATCH RESEND -tip v2 2/7] x86/insn-eval: Fix signedness bug in segment selector handling Uros Bizjak
2026-04-28 16:03 ` Uros Bizjak [this message]
2026-04-28 16:03 ` [PATCH RESEND -tip v2 4/7] x86/ptrace: Use unsigned short for segment values in get_segment_reg() Uros Bizjak
2026-04-28 16:03 ` [PATCH RESEND -tip v2 5/7] x86/kexec: store segment registers directly to memory in crash_setup_regs() Uros Bizjak
2026-04-28 16:03 ` [PATCH RESEND -tip v2 6/7] x86/segment: Introduce savesegment_mem16() helper to write segment selectors to memory Uros Bizjak
2026-04-28 16:03 ` [PATCH RESEND -tip v2 7/7] x86/process: Use savesegment_mem16() when saving segment selectors Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428160443.3593331-3-ubizjak@gmail.com \
--to=ubizjak@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox