From: Jakub Kicinski <kuba@kernel.org>
To: Jordan Rhee <jordanrhee@google.com>
Cc: Harshitha Ramamurthy <hramamurthy@google.com>,
netdev@vger.kernel.org, joshwash@google.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, richardcochran@gmail.com, willemb@google.com,
nktgrg@google.com, jfraker@google.com, ziweixiao@google.com,
maolson@google.com, thostet@google.com, jefrogers@google.com,
alok.a.tiwari@oracle.com, yyd@google.com,
jacob.e.keller@intel.com, linux-kernel@vger.kernel.org,
Naman Gulati <namangulati@google.com>
Subject: Re: [PATCH net-next v4 3/3] gve: implement PTP gettimex64
Date: Tue, 28 Apr 2026 16:22:53 -0700 [thread overview]
Message-ID: <20260428162253.2228dd5f@kernel.org> (raw)
In-Reply-To: <CA+mzVtuviy1k5-m3saQEtCL0YPUwfKBJWjC54rw+1y9ypFM+Ow@mail.gmail.com>
On Tue, 28 Apr 2026 08:49:31 -0700 Jordan Rhee wrote:
> > > +static int gve_cycles_to_clock_fn(ktime_t *device_time,
> > > + struct system_counterval_t *system_counterval,
> > > + void *ctx)
> >
> > Does this do anything GVE specific??
>
> No, however, I would caution against adding an API to the kernel to
> convert TSC to ktime since this could invite further abuses of TSC.
I don't understand. You caution against doing something you're about
to do? In case I didn't ask for it already - please make sure you CC
time keeping maintainers on v5.
prev parent reply other threads:[~2026-04-28 23:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 23:39 [PATCH net-next v4 0/3] gve: add support for PTP gettimex64 Harshitha Ramamurthy
2026-04-06 23:40 ` [PATCH net-next v4 1/3] gve: skip error logging for retryable AdminQ commands Harshitha Ramamurthy
2026-04-06 23:40 ` [PATCH net-next v4 2/3] gve: make nic clock reads thread safe Harshitha Ramamurthy
2026-04-06 23:40 ` [PATCH net-next v4 3/3] gve: implement PTP gettimex64 Harshitha Ramamurthy
2026-04-10 3:16 ` Jakub Kicinski
2026-04-28 15:49 ` Jordan Rhee
2026-04-28 23:22 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428162253.2228dd5f@kernel.org \
--to=kuba@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jefrogers@google.com \
--cc=jfraker@google.com \
--cc=jordanrhee@google.com \
--cc=joshwash@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maolson@google.com \
--cc=namangulati@google.com \
--cc=netdev@vger.kernel.org \
--cc=nktgrg@google.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=thostet@google.com \
--cc=willemb@google.com \
--cc=yyd@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox