public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: rpi-panel-attiny: add back GPIOLIB dependency
@ 2026-04-29 13:57 Arnd Bergmann
  2026-04-30  4:13 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-04-29 13:57 UTC (permalink / raw)
  To: Mark Brown
  Cc: Arnd Bergmann, Liam Girdwood, Marek Vasut, Bartosz Golaszewski,
	linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

This driver provides a gpio chip, which is only possible when GPIOLIB
is enabled, which was previously guaranteed by the CONFIG_OF_GPIO
dependency that is now gone:

ERROR: modpost: "gpiochip_get_data" [drivers/regulator/rpi-panel-attiny-regulator.ko] undefined!
ERROR: modpost: "devm_gpiochip_add_data_with_key" [drivers/regulator/rpi-panel-attiny-regulator.ko] undefined!

Add an explicit GPIOLIB dependency instead.

Fixes: bf017304fce1 ("regulator: drop unneeded dependencies on OF_GPIO")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 390b7e88868a..5d66ca3e1f8a 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -1233,6 +1233,7 @@ config REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY
 	tristate "Raspberry Pi 7-inch touchscreen panel ATTINY regulator"
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on BACKLIGHT_CLASS_DEVICE
+	depends on GPIOLIB
 	depends on I2C
 	select REGMAP_I2C
 	help
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: rpi-panel-attiny: add back GPIOLIB dependency
  2026-04-29 13:57 [PATCH] regulator: rpi-panel-attiny: add back GPIOLIB dependency Arnd Bergmann
@ 2026-04-30  4:13 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2026-04-30  4:13 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Arnd Bergmann, Liam Girdwood, Marek Vasut, Bartosz Golaszewski,
	linux-kernel

On Wed, 29 Apr 2026 15:57:34 +0200, Arnd Bergmann wrote:
> regulator: rpi-panel-attiny: add back GPIOLIB dependency

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.1

Thanks!

[1/1] regulator: rpi-panel-attiny: add back GPIOLIB dependency
      https://git.kernel.org/broonie/regulator/c/7dfc00630220

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-04-30 11:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 13:57 [PATCH] regulator: rpi-panel-attiny: add back GPIOLIB dependency Arnd Bergmann
2026-04-30  4:13 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox