From: Jack Lee <skunkolee@gmail.com>
To: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jack Lee <skunkolee@gmail.com>,
Josh Poimboeuf <jpoimboe@kernel.org>, Kees Cook <kees@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linux-media@vger.kernel.org (open list:STAGING - ATOMISP DRIVER),
linux-kernel@vger.kernel.org (open list:INTEL MID (Mobile
Internet Device) PLATFORM),
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM)
Subject: [PATCH] staging: media: atomisp: ov2722: clean up ov2722_startup()
Date: Wed, 29 Apr 2026 17:41:06 -0600 [thread overview]
Message-ID: <20260429234110.7879-1-skunkolee@gmail.com> (raw)
Remove stale TODO comment that has been present since the file
was first added to staging in 2017 and was never really acted on.
Also replace return ret with return 0 since ret is guaranteed
to be zero at that point, both write calls return early on
failure.
Signed-off-by: Jack Lee <skunkolee@gmail.com>
---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 2c41c496daa6..fcd71cc55731 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -599,7 +599,6 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on)
return ret;
}
-/* TODO: remove it. */
static int ov2722_startup(struct v4l2_subdev *sd)
{
struct ov2722_device *dev = to_ov2722_sensor(sd);
@@ -619,7 +618,7 @@ static int ov2722_startup(struct v4l2_subdev *sd)
return ret;
}
- return ret;
+ return 0;
}
static int ov2722_set_fmt(struct v4l2_subdev *sd,
--
2.54.0
next reply other threads:[~2026-04-29 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 23:41 Jack Lee [this message]
2026-04-30 6:05 ` [PATCH] staging: media: atomisp: ov2722: clean up ov2722_startup() Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2026-04-29 2:03 auth
2026-04-29 5:48 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260429234110.7879-1-skunkolee@gmail.com \
--to=skunkolee@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mingo@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox