public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bentley Blacketer <sonionwhat@gmail.com>
Cc: vireshk@kernel.org, johan@kernel.org, elder@kernel.org,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
Date: Thu, 30 Apr 2026 19:38:39 +0200	[thread overview]
Message-ID: <2026043002-dinghy-carefully-d8d2@gregkh> (raw)
In-Reply-To: <20260430173045.4619-1-sonionwhat@gmail.com>

On Thu, Apr 30, 2026 at 01:30:45PM -0400, Bentley Blacketer wrote:
> The original dev_info call was intentionally temporary, with a FIXME
> comment noting it should be downgraded to dev_dbg once modules with
> valid VID/PID values were common. Project Ara was cancelled in 2016,
> so that time has long passed.
> 
> Remove the FIXME comment and downgrade to dev_dbg as originally intended.
> 
> Tested via code inspection only, as Project Ara hardware is no longer
> available.
> 
> Signed-off-by: Bentley Blacketer  <sonionwhat@gmail.com>
> Signed-off-by: Bentley Blacketer <sonionwhat@gmail.com>

Why twice?

> ---
>  drivers/staging/greybus/bootrom.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)

No list of what changed from previous versions?

> 
> diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c
> index 83921d90c..058044ba7 100644
> --- a/drivers/staging/greybus/bootrom.c
> +++ b/drivers/staging/greybus/bootrom.c
> @@ -163,18 +163,13 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
>  	 *
>  	 * XXX Name it properly..
>  	 */
> -	snprintf(firmware_name, sizeof(firmware_name),
> +snprintf(firmware_name, sizeof(firmware_name),


Why this change?

Please always run your patches through checkpatch.pl before sending them
out.

thanks,

greg k-h

      reply	other threads:[~2026-04-30 17:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 17:30 [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name Bentley Blacketer
2026-04-30 17:38 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026043002-dinghy-carefully-d8d2@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sonionwhat@gmail.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox