From: kernel test robot <lkp@intel.com>
To: Bentley Blacketer <sonionwhat@gmail.com>, gregkh@linuxfoundation.org
Cc: oe-kbuild-all@lists.linux.dev, vireshk@kernel.org,
johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Bentley Blacketer <sonionwhat@gmail.com>
Subject: Re: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
Date: Tue, 5 May 2026 09:55:28 +0800 [thread overview]
Message-ID: <202605050911.O85GmqxE-lkp@intel.com> (raw)
In-Reply-To: <20260430173045.4619-1-sonionwhat@gmail.com>
Hi Bentley,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Bentley-Blacketer/staging-greybus-bootrom-replace-dev_info-with-dev_dbg-for-firmware-name/20260505-034304
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20260430173045.4619-1-sonionwhat%40gmail.com
patch subject: [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name
config: hexagon-randconfig-r071-20260505 (https://download.01.org/0day-ci/archive/20260505/202605050911.O85GmqxE-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
smatch: v0.5.0-9065-ge9cc34fd
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605050911.O85GmqxE-lkp@intel.com/
smatch warnings:
drivers/staging/greybus/bootrom.c:166 find_firmware() warn: inconsistent indenting
vim +166 drivers/staging/greybus/bootrom.c
f1e941a6e4b71a drivers/staging/greybus/firmware.c Viresh Kumar 2015-11-26 142
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 143 /* This returns path of the firmware blob on the disk */
68793c4c8824a0 drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-22 144 static int find_firmware(struct gb_bootrom *bootrom, u8 stage)
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 145 {
5a53e02eaf223c drivers/staging/greybus/bootrom.c Viresh Kumar 2016-04-03 146 struct gb_connection *connection = bootrom->connection;
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 147 struct gb_interface *intf = connection->bundle->intf;
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 148 char firmware_name[49];
fc41c2da44c510 drivers/staging/greybus/firmware.c Eli Sennesh 2016-01-08 149 int rc;
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 150
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 151 /* Already have a firmware, free it */
5a53e02eaf223c drivers/staging/greybus/bootrom.c Viresh Kumar 2016-04-03 152 free_firmware(bootrom);
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 153
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 154 /* Bootrom protocol is only supported for loading Stage 2 firmware */
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 155 if (stage != 2) {
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 156 dev_err(&connection->bundle->dev, "Invalid boot stage: %u\n",
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 157 stage);
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 158 return -EINVAL;
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 159 }
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 160
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 161 /*
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 162 * Create firmware name
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 163 *
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 164 * XXX Name it properly..
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 165 */
af0b4d5a19e3d4 drivers/staging/greybus/firmware.c Johan Hovold 2015-08-28 @166 snprintf(firmware_name, sizeof(firmware_name),
8a704565ebda96 drivers/staging/greybus/bootrom.c Greg Kroah-Hartman 2016-07-20 167 FW_NAME_PREFIX "%08x_%08x_%08x_%08x_s2l.tftf",
b32a5c5346bdaa drivers/staging/greybus/firmware.c Viresh Kumar 2015-12-22 168 intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
56c78715eaaeba drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-16 169 intf->vendor_id, intf->product_id);
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 170
6472c9b9299508 drivers/staging/greybus/bootrom.c Bentley Blacketer 2026-04-30 171 dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
eb8fafdfb9fce9 drivers/staging/greybus/firmware.c Greg Kroah-Hartman 2016-01-20 172 firmware_name);
5a53e02eaf223c drivers/staging/greybus/bootrom.c Viresh Kumar 2016-04-03 173 rc = request_firmware(&bootrom->fw, firmware_name,
0a72bd36df9478 drivers/staging/greybus/firmware.c Greg Kroah-Hartman 2015-10-14 174 &connection->bundle->dev);
2d6f1c29988c0f drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-22 175 if (rc) {
68793c4c8824a0 drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-22 176 dev_err(&connection->bundle->dev,
68793c4c8824a0 drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-22 177 "failed to find %s firmware (%d)\n", firmware_name, rc);
2d6f1c29988c0f drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-22 178 }
2d6f1c29988c0f drivers/staging/greybus/bootrom.c Viresh Kumar 2016-07-22 179
fc41c2da44c510 drivers/staging/greybus/firmware.c Eli Sennesh 2016-01-08 180 return rc;
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 181 }
90f1b617d88f14 drivers/staging/greybus/firmware.c Viresh Kumar 2015-08-12 182
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-05-05 1:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 17:30 [PATCH v3] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name Bentley Blacketer
2026-04-30 17:38 ` Greg KH
2026-05-05 1:55 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202605050911.O85GmqxE-lkp@intel.com \
--to=lkp@intel.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sonionwhat@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox