From: Michal Pecio <michal.pecio@gmail.com>
To: "Heitor Alves de Siqueira" <halves@igalia.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-dev@igalia.com>,
<syzbot+abbfd103085885cf16a2@syzkaller.appspotmail.com>,
<stable@kernel.org>
Subject: Re: [PATCH v2] usb: usbtmc: reject invalid interrupt endpoints
Date: Thu, 30 Apr 2026 23:04:22 +0200 [thread overview]
Message-ID: <20260430230300.5a67c1dd.michal.pecio@gmail.com> (raw)
In-Reply-To: <20260430224849.3322afb0.michal.pecio@gmail.com>
On Thu, 30 Apr 2026 22:48:49 +0200, Michal Pecio wrote:
> The only change to support USB488 devices with wMaxPacketSize == 1
> should be increasing URB size to at least 2 bytes. But I wouldn't
> bother when no such HW is known to exist, and surely not as part of
> a barely related bugfix patch.
Correction: I noticed that USB488 spec Table 22 requires wMaxPacketSize
to be exactly 0x02, unless the device sends vendor notifications.
One could argue that 0x01 is covered by this exception, but that's
obviously against the intent.
So for bInterfaceProtocol 1 devices, requiring wMaxPacketSize >= 2
should be OK, but bInterfaceProtocol 0 devices are unclear.
Regards,
Michal
prev parent reply other threads:[~2026-04-30 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 18:04 [PATCH v2] usb: usbtmc: reject invalid interrupt endpoints Heitor Alves de Siqueira
2026-04-23 22:28 ` Michal Pecio
2026-04-28 19:55 ` Heitor Alves de Siqueira
2026-04-28 22:16 ` Michal Pecio
2026-04-30 18:31 ` Heitor Alves de Siqueira
2026-04-30 20:48 ` Michal Pecio
2026-04-30 21:04 ` Michal Pecio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260430230300.5a67c1dd.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=halves@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@kernel.org \
--cc=syzbot+abbfd103085885cf16a2@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox