From: William Breathitt Gray <wbg@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: William Breathitt Gray <wbg@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
driver-core@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isa: switch to dynamic root device
Date: Sun, 3 May 2026 14:08:00 +0900 [thread overview]
Message-ID: <20260503050801.427989-1-wbg@kernel.org> (raw)
In-Reply-To: <20260424102400.2615677-1-johan@kernel.org>
On Fri, Apr 24, 2026 at 12:24:00PM +0200, Johan Hovold wrote:
> Driver core expects devices to be dynamically allocated and will, for
> example, complain loudly if a device that lacks a release function is
> ever freed.
>
> Use root_device_register() to allocate and register the root device
> instead of open coding using a static device.
>
> Note that this also fixes a reference leak in case device_register()
> fails which may be flagged by static checkers.
>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Hi Johan,
Would you resend with a Fixes tag and CC stable@vger.kernel.org so we
can get this patch picked up in the stable trees as well?
Thanks,
William Breathitt Gray
next prev parent reply other threads:[~2026-05-03 5:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 10:24 [PATCH] isa: switch to dynamic root device Johan Hovold
2026-05-03 5:08 ` William Breathitt Gray [this message]
2026-05-03 15:50 ` Danilo Krummrich
2026-05-04 6:35 ` William Breathitt Gray
2026-05-04 6:52 ` Greg Kroah-Hartman
2026-05-04 7:05 ` William Breathitt Gray
2026-05-04 20:32 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260503050801.427989-1-wbg@kernel.org \
--to=wbg@kernel.org \
--cc=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox