public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Piyush Patle <piyushpatle228@gmail.com>
To: Andreas Klinger <ak@it-klinger.de>, Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v6 00/11] iio: adc: hx711: add HX710B support
Date: Sun,  3 May 2026 17:39:29 +0530	[thread overview]
Message-ID: <20260503120949.80292-1-piyushpatle228@gmail.com> (raw)

Add support for the AVIA HX710B ADC, a HX711-compatible converter with
the same GPIO interface but a different channel-selection model and a
fixed gain of 128.

Compared to v5, this series is unchanged functionally and only folds in
the remaining review nits:

- keep the per-variant probe local declarations in reversed xmas tree
  order
- add a preparatory split-assignment patch before the loop-iterator
  cleanup, then keep the loop indices signed to match trailing_pulses
- replace the 24-bit read loop bound with a named constant while
  touching the same code
- keep the driver wording aligned on "weigh sensor modules"
- rename fixed_gain to has_fixed_gain and drop the channel_set cast

The DT binding split from v5 is kept as-is:

- cleanup of the existing HX711 binding text
- HX711-only VSUP documentation
- HX711-only RATE GPIO documentation
- HX710B binding addition

Tested on PocketBeagle2 with an HX710B breakout module. The device
probed successfully, all three channels returned stable raw readings,
and alternating reads confirmed channel switching between the
differential input and the DVDD-AVDD supply monitor path.

Build-tested with:
- make -s W=1 drivers/iio/adc/hx711.o
- make -s dt_binding_check \
  DT_SCHEMA_FILES=Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
- pahole -C hx711_chip_info drivers/iio/adc/hx711.o

pahole reports hx711_chip_info as 40 bytes with no internal holes. The
remaining 7 bytes are tail padding from 8-byte pointer alignment.

Changes in v6:
- Fold the remaining review nits into the original 11-patch series
  rather than adding follow-up fixes.
- Keep hx711_probe() local declarations in reversed xmas tree order in
  the hx711_chip_info patch.
- Add a preparatory split-assignment patch before the loop-iterator
  cleanup and keep the iterator types signed to match trailing_pulses.
- Replace the 24-bit hx711_read() loop bound with HX711_DATA_BITS in
  the loop-iterator patch.
- Keep the driver header wording as "weigh sensor modules".
- Rename fixed_gain to has_fixed_gain and make channel_set signed so
  the HX710B channel comparison no longer needs a cast.

Piyush Patle (11):
  dt-bindings: iio: adc: hx711: clean up existing binding text
  dt-bindings: iio: adc: hx711: add VSUP supply property
  dt-bindings: iio: adc: hx711: add RATE GPIO property
  dt-bindings: iio: adc: hx711: add HX710B support
  iio: adc: hx711: move scale computation to per-device storage
  iio: adc: hx711: introduce hx711_chip_info structure
  iio: adc: hx711: pass trailing pulse count into hx711_read
  iio: adc: hx711: split variable assignments in hx711_read and
    hx711_reset
  iio: adc: hx711: localize loop iterators in hx711_read
  iio: adc: hx711: pass iio_chan_spec to hx711_reset_read
  iio: adc: hx711: add support for HX710B

 .../bindings/iio/adc/avia-hx711.yaml          |  77 ++++-
 drivers/iio/adc/Kconfig                       |   8 +-
 drivers/iio/adc/hx711.c                       | 299 ++++++++++++++----
 3 files changed, 308 insertions(+), 76 deletions(-)

-- 
2.43.0

             reply	other threads:[~2026-05-03 12:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 12:09 Piyush Patle [this message]
2026-05-03 12:09 ` [PATCH v6 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-03 12:09 ` [PATCH v6 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-04  6:51   ` Krzysztof Kozlowski
2026-05-04 15:58     ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-04  6:52   ` Krzysztof Kozlowski
2026-05-03 12:09 ` [PATCH v6 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-03 12:09 ` [PATCH v6 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-04 14:25   ` Andy Shevchenko
2026-05-04 16:00     ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-04 14:48   ` Andy Shevchenko
2026-05-03 12:09 ` [PATCH v6 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-03 12:09 ` [PATCH v6 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset Piyush Patle
2026-05-04 15:46   ` Andy Shevchenko
2026-05-04 16:03   ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-04 15:48   ` Andy Shevchenko
2026-05-03 12:09 ` [PATCH v6 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-05-04 16:05   ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-04 15:52   ` Andy Shevchenko
2026-05-04 16:59     ` Jonathan Cameron
2026-05-04 16:02   ` Jonathan Cameron
2026-05-04 15:54 ` [PATCH v6 00/11] iio: adc: hx711: add HX710B support Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260503120949.80292-1-piyushpatle228@gmail.com \
    --to=piyushpatle228@gmail.com \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox