From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Piyush Patle" <piyushpatle228@gmail.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property
Date: Mon, 4 May 2026 16:58:45 +0100 [thread overview]
Message-ID: <20260504165845.5875e833@jic23-huawei> (raw)
In-Reply-To: <20260504-simple-garnet-quokka-bfd9b3@quoll>
On Mon, 4 May 2026 08:51:37 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Sun, May 03, 2026 at 05:39:31PM +0530, Piyush Patle wrote:
> > Document the optional VSUP supply used by the HX711 on-chip regulator.
> >
> > Keep this separate from the HX710B support so the existing HX711
>
> What does HX710B mean? There is no such device in this binding.
Yeah. Just drop this bit - it's reasoning that might belong in
a change log.
>
> > binding extension stands on its own.
> >
> > No functional change for existing users.
>
> There is functional change - you added a new supply.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-05-04 15:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-03 12:09 [PATCH v6 00/11] iio: adc: hx711: add HX710B support Piyush Patle
2026-05-03 12:09 ` [PATCH v6 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-03 12:09 ` [PATCH v6 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-04 6:51 ` Krzysztof Kozlowski
2026-05-04 15:58 ` Jonathan Cameron [this message]
2026-05-03 12:09 ` [PATCH v6 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-04 6:52 ` Krzysztof Kozlowski
2026-05-03 12:09 ` [PATCH v6 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-03 12:09 ` [PATCH v6 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-04 14:25 ` Andy Shevchenko
2026-05-04 16:00 ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-04 14:48 ` Andy Shevchenko
2026-05-03 12:09 ` [PATCH v6 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-03 12:09 ` [PATCH v6 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset Piyush Patle
2026-05-04 15:46 ` Andy Shevchenko
2026-05-04 16:03 ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-04 15:48 ` Andy Shevchenko
2026-05-03 12:09 ` [PATCH v6 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-05-04 16:05 ` Jonathan Cameron
2026-05-03 12:09 ` [PATCH v6 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-04 15:52 ` Andy Shevchenko
2026-05-04 16:59 ` Jonathan Cameron
2026-05-04 16:02 ` Jonathan Cameron
2026-05-04 15:54 ` [PATCH v6 00/11] iio: adc: hx711: add HX710B support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504165845.5875e833@jic23-huawei \
--to=jic23@kernel.org \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox